New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx190 Modify the hit analyzer code to make tree or a set of histos #26314
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26314/9014
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Validation/HGCalValidation @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 the provided test cfg runs smoothly on a few hundred events |
PR description:
Modify the hit analysis code in test area to create a ROOT tree (old version) or a set of histograms depending on a run time parameter (useful for geometry tests). Also adopted the histogram ranges for V10 geometry option.
PR validation:
Tested with the outputs of the workflow 29034.0
if this PR is a backport please specify the original PR:
It is not a backport and adopted to standard CMSSW conventions