Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cosmic track splitting validation #2632

Merged

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Feb 25, 2014

This is an update to the cosmic track splitting validation. It adds more variables into the tree, including the errors for split and original track variables.

I was asked by the conveners to create this pull request for the cosmic track splitting validation.

This is a backport of pull request #2452 in 71X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes for CMSSW_7_0_X.

Update to cosmic track splitting validation

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@rcastello
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Mar 25, 2014

@davidlange6 do we need this in 70X at this point? If not any objections to closing it?

@frmeier
Copy link
Contributor

frmeier commented Apr 2, 2014

Sorry for the late reply, was away and traveled.
Although it does not hurt if we get it later in, it doesn't harm to put
it in now. Changes are pretty orthogonal and having it in 70 is handy.
Same justification applies to #2630 and #2331 (where the latter may be
rated more important).

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Apr 8, 2014

Do we actually need this in 70X?

@mmusich
Copy link
Contributor

mmusich commented Apr 8, 2014

Since we are going to get TkAl AlcaRecos processed in 70X for the CSA14 exercise I would say yes

@frmeier
Copy link
Contributor

frmeier commented Apr 9, 2014

Whenever we have samples in 70X we need it.

@frmeier
Copy link
Contributor

frmeier commented Apr 15, 2014

This has been discussed at yesterday's AlCaDB meeting. Yes, it is needed to validate the dataset we will soon receive. Please proceed.

@diguida
Copy link
Contributor

diguida commented Apr 15, 2014

Hi!
As @frmeier pointed out, this PR is needed for the cosmic samples requested within CSA14.

davidlange6 added a commit that referenced this pull request Apr 15, 2014
Update to cosmic track splitting validation
@davidlange6 davidlange6 merged commit 663eca9 into cms-sw:CMSSW_7_0_X Apr 15, 2014
@hroskes hroskes deleted the cosmic-track-splitting-update-70X branch November 3, 2014 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants