Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small fix to dqmMemoryStats.py #26336

Merged
merged 1 commit into from Apr 5, 2019

Conversation

andrius-k
Copy link

PR description:

A small fix to a dqmMemoryStats.py tool.

PR validation:

The tool was tested locally after applying the fix.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

The code-checks are being triggered in jenkins.

@andrius-k
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26336/9050

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33930/console Started: 2019/04/03 15:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

A new Pull Request was created by @andrius-k (Andrius) for master.

It involves the following packages:

DQMServices/FileIO

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26336/33930/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link
Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2019

@andrius-k for my understanding which observed issue is being addressed by this fix?

@schneiml
Copy link
Contributor

schneiml commented Apr 5, 2019

@fabiocos the regular expression assumes that all non-histogram MonitoElements (which are parsed using this expression) need to have non-empty values. That is typically true in our DQM output, but it blew up now and then when values are not correctly populated.

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2019

+1

@schneiml ok, thanks for the clarification

@cmsbuild cmsbuild merged commit f596ddc into cms-sw:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants