Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep hidden valley and dark matter particles in miniAOD [102X] #26340

Merged
merged 1 commit into from Apr 5, 2019

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Apr 3, 2019

backport of #26339

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Apr 3, 2019
@kpedro88
Copy link
Contributor Author

kpedro88 commented Apr 3, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33934/console Started: 2019/04/03 16:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_10_2_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @perrotta, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26340/33934/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007206
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@santocch
Copy link

santocch commented Apr 4, 2019

+1

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2019

+1

  • The additions will be only effective for a tiny number of new physocs signal simulations
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2019

+1

@cmsbuild cmsbuild merged commit d69f103 into cms-sw:CMSSW_10_2_X Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants