New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD Geometry: avoid dependence on namespace in volume name string #26344
Conversation
…test, not for Geant4)
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26344/9059
|
please test workflow 29034.0 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Geometry/MTDCommonData @civanch, @Dr15Jones, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
type bugfix |
+1 |
PR description:
Follow-up of #26307 : the DetId for ETL negative size is correctly reconstructed in the geometry test, but within Geant4 the namespace of the volume is not present in the string list used to build the basename. This is now fixed.
PR validation:
The residual issue was detected with the MTD validation package under preparation (PR to arrive independently). Enabling detailed verbosity within step1 of test workflows shows now that ETDetIds are correctly generated:
SimHits are now visible in the test https://github.com/casarsa/cmssw/blob/mc-valMTD-devel-new/Validation/MtdValidation/plugins/EtlSimHitsValidation.cc as can be seen by the produced plots:
SimHitNeg.pdf
SimHitPos.pdf