Replace boost_python parameterset reader with a python3 version #26377
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26377/9121
Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26377/9121/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26377/9122
|
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @alja can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test
On 6 Apr 2019, at 20:31, cmsbuild <notifications@github.com<mailto:notifications@github.com>> wrote:
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26377/9122
* This PR adds an extra 56KB to repository
* Found files with invalid states:
* FWCore/PythonParameterSet/BuildFile.xml:
* Deleted: cc6db46<cc6db46>
* Added: 9e22e8d<9e22e8d>
* FWCore/PythonParameterSet/test/makeprocess_t.cppunit.cc<http://makeprocess_t.cppunit.cc>:
* Deleted: cc6db46<cc6db46>
* Added: 9e22e8d<9e22e8d>
* FWCore/PythonParameterSet/test/makepset_t.cppunit.cc<http://makepset_t.cppunit.cc>:
* Deleted: cc6db46<cc6db46>
* Added: 9e22e8d<9e22e8d>
* FWCore/PythonParameterSet/test/BuildFile.xml:
* Deleted: cc6db46<cc6db46>
* Added: 9e22e8d<9e22e8d>
* FWCore/PythonParameterSet/python/test/testTask_cff.py:
* Deleted: cc6db46<cc6db46>
* Added: 9e22e8d<9e22e8d>
* FWCore/PythonParameterSet/test/ufip.txt:
* Deleted: cc6db46<cc6db46>
* Added: 9e22e8d<9e22e8d>
* FWCore/PythonParameterSet/test/fip.txt:
* Deleted: cc6db46<cc6db46>
* Added: 9e22e8d<9e22e8d>
* FWCore/PythonParameterSet/test/processbuilder_t.cppunit.cpp:
* Deleted: cc6db46<cc6db46>
* Added: 9e22e8d<9e22e8d>
* FWCore/PythonParameterSet/test/readpsetsfrom_t.cppunit.cc<http://readpsetsfrom_t.cppunit.cc>:
* Deleted: cc6db46<cc6db46>
* Added: 9e22e8d<9e22e8d>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#26377 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw01G6RSguRkBtKPzRc0lHcS775Qfks5veOfNgaJpZM4cgT0w>.
|
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26377/9128
|
|
Pull request #26377 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @alja can you please check and sign again. |
| @@ -29,7 +29,7 @@ int main(int argc, char **argv) try { | |||
| config = std::string(argv[1]); | |||
| } | |||
|
|
|||
| std::shared_ptr<edm::ParameterSet> parameterSet = edm::boost_python::readConfig(config); | |||
| std::shared_ptr<edm::ParameterSet> parameterSet = edm::readConfig(config); | |||
There was a problem hiding this comment.
ok, pybind11 is already inside ParameterSetReader, so no need to call it explicitly...
|
please test |
|
The tests are being triggered in jenkins. |
|
yes, that is why I moved these two tools to FWCore/ParameterSetReader. They should be derived from whatever the default system CMSSW uses for its parameter set interface.
… On Apr 7, 2019, at 6:51 PM, Fabio Cossutti ***@***.***> wrote:
@fabiocos commented on this pull request.
In FWCore/ParameterSetReader/bin/edmConfigHash.cpp:
> @@ -29,7 +29,7 @@ int main(int argc, char **argv) try {
config = std::string(argv[1]);
}
- std::shared_ptr<edm::ParameterSet> parameterSet = edm::boost_python::readConfig(config);
+ std::shared_ptr<edm::ParameterSet> parameterSet = edm::readConfig(config);
ok, pybind11 is already inside ParameterSetReader, so no need to call it explicitly...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Comparison job queued. |
|
@Dr15Jones the latest addition reintroduce the two utilities, the rest is unchanged. Do you confirm the signature? |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
visualization-approved
and removed
core-pending
pending-signatures
visualization-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Despite the big changes, there is NO change to cmsRun itself aside from some package renaming. And, the big chunk of new code is a direct copy of old code - this duplication (which I don't see how to avoid, but interested in any ideas) will go away when we drop support for python2 in cmsRun
PR validation:
unit tests and basic runTheMatrix ok.
if this PR is a backport please specify the original PR: