DD4hep: DD World Built from a DD4hep-based Geometry #26383

ianna · 2019-04-08T12:27:48Z

PR description:

DDWorld to access G4 geometry
Converter to G4 geometry test

PR validation:

@mrodozov - this PR will not compile until the dd4hep-geant4 tool is setup correctly. When it does, it can be merged.

if this PR is a backport please specify the original PR:

no back port is needed

cmsbuild · 2019-04-08T12:28:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-08T12:35:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26383/9133

This PR adds an extra 16KB to repository

cmsbuild · 2019-04-08T12:36:07Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4Core/DD4hepGeometry

The following packages do not have a category, yet:

SimG4Core/DD4hepGeometry
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

mrodozov · 2019-04-08T14:08:36Z

@ianna I fixed the includes but now the code complains about "DDG4/Detector.h" not found in the DDG4 includes:
https://github.com/cms-sw/cmssw/pull/26383/files#diff-19bce7dd0d1ec0083d7be74adfb4e755R6
is it DD4hep/Detector.h ?

cmsbuild · 2019-04-08T14:14:23Z

The code-checks are being triggered in jenkins.

ianna · 2019-04-08T14:14:48Z

Thanks @mrodozov ! Please, let me know when can I test it.

cmsbuild · 2019-04-08T14:20:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26383/9136

This PR adds an extra 16KB to repository

cmsbuild · 2019-04-08T14:21:29Z

Pull request #26383 was updated. @cmsbuild can you please check and sign again.

mrodozov · 2019-04-09T07:53:29Z

please test

cmsbuild · 2019-04-09T07:54:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34066/console Started: 2019/04/09 09:55

cmsbuild · 2019-04-09T07:58:40Z

-1

Tested at: c58a754

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26383/34066/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found compilation error when building:

>> Package SimG4Core/DD4hepGeometry built
>> Entering Package SimG4Core/DD4hepGeometry
Entering library rule at SimG4Core/DD4hepGeometry
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-08-2300/src/SimG4Core/DD4hepGeometry/src/DD4hep_DDDWorld.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-08-2300/src/SimG4Core/DD4hepGeometry/src/DD4hep_DDDWorld.cc: In constructor 'cms::DDDWorld::DDDWorld(const cms::DDDetector*)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-08-2300/src/SimG4Core/DD4hepGeometry/src/DD4hep_DDDWorld.cc:19:38: error: binding reference of type 'dd4hep::Detector&' to 'const dd4hep::Detector' discards qualifiers
   dd4hep::sim::Geant4Converter g4Geo(detector);
                                      ^~~~~~~~
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-08-2300/src/SimG4Core/DD4hepGeometry/src/DD4hep_DDDWorld.cc:4:0:
/cvmfs/cms-ib.cern.ch/nweek-02571/slc7_amd64_gcc700/external/dd4hep/v01-10x-dplpph/include/DDG4/Geant4Converter.h:58:7: note:   initializing argument 1 of 'dd4hep::sim::Geant4Converter::Geant4Converter(dd4hep::Detector&)'
       Geant4Converter(Detector& description);

Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(/build/cmsbld/jenkins/workspace/ib-any-integration/cms-bot/buildLogAnalyzer.py' --logDir /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-08-2300/tmp/slc7_amd64_gcc700/cache/log/src '||' 'true)'
++ scram build outputlog
Entering library rule at SimG4Core/DD4hepGeometry
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-08-2300/src/SimG4Core/DD4hepGeometry/src/DD4hep_DDDWorld.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-08-2300/src/SimG4Core/DD4hepGeometry/src/DD4hep_DDDWorld.cc:19:32: error: no matching constructor for initialization of 'dd4hep::sim::Geant4Converter'
  dd4hep::sim::Geant4Converter g4Geo(detector);
                               ^     ~~~~~~~~
/cvmfs/cms-ib.cern.ch/nweek-02571/slc7_amd64_gcc700/external/dd4hep/v01-10x-dplpph/include/DDG4/Geant4Converter.h:32:11: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'const dd4hep::Detector' to 'const dd4hep::sim::Geant4Converter' for 1st argument
    class Geant4Converter : public detail::GeoHandler, public Geant4Mapping {
          ^

cmsbuild · 2019-04-09T07:58:42Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2019-04-10T11:48:56Z

+1
Tested at: 84a3a0d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26383/34114/summary.html

cmsbuild · 2019-04-10T11:49:03Z

Comparison job queued.

ianna · 2019-04-10T11:57:00Z

assign simulation
assign geometry

cmsbuild · 2019-04-10T11:59:23Z

New categories assigned: simulation

@civanch,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks

ianna · 2019-04-10T12:00:40Z

@fabiocos - this is a new package in Simulation with dependency on a dd4hep DDG4 static library.

cmsbuild · 2019-04-10T13:05:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26383/34114/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3140495
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3140297
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

civanch · 2019-04-10T14:30:43Z

@ianna , I am a bit confused. If it is a test, why these are producers in plugin directory instead of test directory? What is the purpose of addition of watchers? What they intend to watch?

SimG4Core/DD4hepGeometry/interface/DD4hep_DDDWorld.h

SimG4Core/DD4hepGeometry/plugins/DD4hep_DDTestG4Geometry.cc

SimG4Core/DD4hepGeometry/plugins/DD4hep_GeometryESProducer.cc

civanch · 2019-04-10T14:53:07Z

@ianna , if this package depends on geant4core, than geant4core cannot depend on DD4Hep. We have circular dependency. In the current situation, SimG4Core depends on DetectorDescription/Core. I would expect we will have the same thing. For today we have SimG4Core/Geometry/test which is intended for testing of geometry only. Why not reuse the same sub-package or creating a new one?

ianna · 2019-04-10T15:04:06Z

This package is intended to test sim dependency on dd4hep. The DDDWorld is a copy of our DDDWorld with an exception that it is in a cms namespace. So is the other class. I was wondering myself about implementations and took liberty to drop some assignments which looked useless to me.

If there’s a circular dependency, we have to address it.

My question is if the package affects the sim jobs in any way.

civanch · 2019-04-14T13:24:17Z

@ianna , current OscarMTProducer (which do real simulation) access would volume via old DD scheme of CMSSW. Your new code seems to provide an access to the world volume. For the test it is fine. It will be good to remove things, which are not connected with geometry in this new producer, this will ensure that we have no circular dependencies (after second look, I am not sure if we really have).

ianna · 2019-05-09T06:00:10Z

@civanch - there is no circular dependency. This package is needed to move further, e.g. to make a new OscarMTProducerFromDD4hep. However, it would help if it's integrated in an IB.

fabiocos · 2019-05-16T07:44:11Z

@ianna @civanch this PR looks now entirely embedded into #26740, which is fully approved, so I would say it may be closed

ianna · 2019-05-16T08:55:06Z

@fabiocos - yes, it's in #26740.

DD world built from a DD4hep-based geometry

134aa48

cmsbuild added this to the CMSSW_10_6_X milestone Apr 8, 2019

cmsbuild added code-checks-pending comparison-pending new-package-pending orp-pending pending-signatures tests-pending labels Apr 8, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 8, 2019

Update DD4hep_DDDWorld.cc

c58a754

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 8, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 8, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 9, 2019

cmsbuild removed the comparison-pending label Apr 9, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 10, 2019

cmsbuild added tests-approved and removed tests-started labels Apr 10, 2019

cmsbuild added the simulation-pending label Apr 10, 2019

This was referenced Apr 10, 2019

DD4hep: Define Vacuum as thin Air #26423

Closed

DD4hep-based Geometry Description to G4 Geometry Converter #26253

Closed

cmsbuild added comparison-available and removed comparison-pending labels Apr 10, 2019

civanch reviewed Apr 10, 2019

View reviewed changes

SimG4Core/DD4hepGeometry/interface/DD4hep_DDDWorld.h Show resolved Hide resolved

civanch reviewed Apr 10, 2019

View reviewed changes

SimG4Core/DD4hepGeometry/plugins/DD4hep_DDTestG4Geometry.cc Show resolved Hide resolved

civanch reviewed Apr 10, 2019

View reviewed changes

SimG4Core/DD4hepGeometry/plugins/DD4hep_GeometryESProducer.cc Show resolved Hide resolved

civanch reviewed Apr 10, 2019

View reviewed changes

SimG4Core/DD4hepGeometry/plugins/DD4hep_GeometryESProducer.cc Show resolved Hide resolved

cmsbuild removed the new-package-pending label Apr 10, 2019

smuzaffar modified the milestones: CMSSW_10_6_X, CMSSW_11_0_X May 14, 2019

ianna closed this May 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DD4hep: DD World Built from a DD4hep-based Geometry #26383

DD4hep: DD World Built from a DD4hep-based Geometry #26383

ianna commented Apr 8, 2019

cmsbuild commented Apr 8, 2019

cmsbuild commented Apr 8, 2019

cmsbuild commented Apr 8, 2019

mrodozov commented Apr 8, 2019 •

edited

cmsbuild commented Apr 8, 2019

ianna commented Apr 8, 2019

cmsbuild commented Apr 8, 2019

cmsbuild commented Apr 8, 2019

mrodozov commented Apr 9, 2019

cmsbuild commented Apr 9, 2019 •

edited

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 10, 2019

cmsbuild commented Apr 10, 2019

ianna commented Apr 10, 2019

cmsbuild commented Apr 10, 2019

ianna commented Apr 10, 2019

cmsbuild commented Apr 10, 2019

civanch commented Apr 10, 2019

civanch commented Apr 10, 2019

ianna commented Apr 10, 2019

civanch commented Apr 14, 2019

ianna commented May 9, 2019

fabiocos commented May 16, 2019

ianna commented May 16, 2019

DD4hep: DD World Built from a DD4hep-based Geometry #26383

DD4hep: DD World Built from a DD4hep-based Geometry #26383

Conversation

ianna commented Apr 8, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Apr 8, 2019

cmsbuild commented Apr 8, 2019

cmsbuild commented Apr 8, 2019

mrodozov commented Apr 8, 2019 • edited

cmsbuild commented Apr 8, 2019

ianna commented Apr 8, 2019

cmsbuild commented Apr 8, 2019

cmsbuild commented Apr 8, 2019

mrodozov commented Apr 9, 2019

cmsbuild commented Apr 9, 2019 • edited

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 9, 2019

cmsbuild commented Apr 10, 2019

cmsbuild commented Apr 10, 2019

ianna commented Apr 10, 2019

cmsbuild commented Apr 10, 2019

ianna commented Apr 10, 2019

cmsbuild commented Apr 10, 2019

civanch commented Apr 10, 2019

civanch commented Apr 10, 2019

ianna commented Apr 10, 2019

civanch commented Apr 14, 2019

ianna commented May 9, 2019

fabiocos commented May 16, 2019

ianna commented May 16, 2019

mrodozov commented Apr 8, 2019 •

edited

cmsbuild commented Apr 9, 2019 •

edited