New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuildFile cleanup: Remove un-used dependency #26395
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26395/9151
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: CommonTools/Utils @cmsbuild, @perrotta, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: c2718c5 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build HeaderConsistency
I found compilation error when building: MinBias.cc:(.text+0xdd3): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()' MinBias.cc:(.text+0xe20): undefined reference to `char const* edm::typelookup::className()' tmp/slc7_amd64_gcc700/src/JetMETCorrections/MinBias/src/JetMETCorrectionsMinBias/MinBias.cc.o: In function `edm::eventsetup::EventSetupRecordImplementation::key() const': MinBias.cc:(.text._ZNK3edm10eventsetup30EventSetupRecordImplementationI18CaloGeometryRecordE3keyEv[_ZNK3edm10eventsetup30EventSetupRecordImplementationI18CaloGeometryRecordE3keyEv]+0x5): undefined reference to `char const* edm::typelookup::className()' MinBias.cc:(.text._ZNK3edm10eventsetup30EventSetupRecordImplementationI18CaloGeometryRecordE3keyEv[_ZNK3edm10eventsetup30EventSetupRecordImplementationI18CaloGeometryRecordE3keyEv]+0xe): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()' collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc700/src/JetMETCorrections/MinBias/src/JetMETCorrectionsMinBias/libJetMETCorrectionsMinBias.so] Error 1 Leaving library rule at JetMETCorrections/MinBias >> Leaving Package L1Trigger/GlobalCaloTrigger arg1= >> Leaving Package JetMETCorrections/MinBias >> Package L1Trigger/GlobalCaloTrigger built |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
I suspect that the error is related somehow indirectly. |
ping |
please test |
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26395/9475
|
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Removed unnecessary dependencies
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: