Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildFile cleanup: Remove un-used dependency #26395

Merged
merged 2 commits into from May 1, 2019
Merged

BuildFile cleanup: Remove un-used dependency #26395

merged 2 commits into from May 1, 2019

Conversation

smuzaffar
Copy link
Contributor

PR description:

Removed unnecessary dependencies

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26395/9151

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34068/console Started: 2019/04/09 09:57

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CommonTools/Utils
DataFormats/EgammaTrackReco

@cmsbuild, @perrotta, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

-1

Tested at: c2718c5

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26395/34068/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency

  • Build:

I found compilation error when building:

MinBias.cc:(.text+0xdd3): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()'
MinBias.cc:(.text+0xe20): undefined reference to `char const* edm::typelookup::className()'
tmp/slc7_amd64_gcc700/src/JetMETCorrections/MinBias/src/JetMETCorrectionsMinBias/MinBias.cc.o: In function `edm::eventsetup::EventSetupRecordImplementation::key() const':
MinBias.cc:(.text._ZNK3edm10eventsetup30EventSetupRecordImplementationI18CaloGeometryRecordE3keyEv[_ZNK3edm10eventsetup30EventSetupRecordImplementationI18CaloGeometryRecordE3keyEv]+0x5): undefined reference to `char const* edm::typelookup::className()'
MinBias.cc:(.text._ZNK3edm10eventsetup30EventSetupRecordImplementationI18CaloGeometryRecordE3keyEv[_ZNK3edm10eventsetup30EventSetupRecordImplementationI18CaloGeometryRecordE3keyEv]+0xe): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc700/src/JetMETCorrections/MinBias/src/JetMETCorrectionsMinBias/libJetMETCorrectionsMinBias.so] Error 1
Leaving library rule at JetMETCorrections/MinBias
>> Leaving Package L1Trigger/GlobalCaloTrigger arg1=
>> Leaving Package JetMETCorrections/MinBias
>> Package L1Trigger/GlobalCaloTrigger built


@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@slava77
Copy link
Contributor

slava77 commented Apr 10, 2019

I suspect that the error is related somehow indirectly.
@smuzaffar did you check this already why it fails in jenkins ? I'd guess that it worked in the local tests.

@slava77
Copy link
Contributor

slava77 commented Apr 23, 2019

I suspect that the error is related somehow indirectly.
@smuzaffar did you check this already why it fails in jenkins ? I'd guess that it worked in the local tests.

ping

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26395/9475

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34401/console Started: 2019/04/29 15:52

@cmsbuild
Copy link
Contributor

Pull request #26395 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26395/34401/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 29, 2019

+1

for #26395 d735c35

  • technical
  • jenkins tests pass and comparisons show no differences

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 1, 2019

merge

@cmsbuild cmsbuild merged commit 2d41ba2 into cms-sw:master May 1, 2019
@santocch
Copy link

santocch commented May 2, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants