Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrange migration in fwk packages for python3 #26410

Merged
merged 1 commit into from Apr 11, 2019

Conversation

davidlange6
Copy link
Contributor

PR description:

at least one unit test in my python3 fwk test fails due to the use of xrange (now range in python3). Migrate using

futurize -f libfuturize.fixes.fix_xrange_with_import -w --no-diffs -n .

(the fwk packages so far)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26410/9178

  • This PR adds an extra 220KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DataFormats/FWLite
DataFormats/PatCandidates
FWCore/Concurrency
FWCore/GuiBrowsers
FWCore/Modules
FWCore/ParameterSet
FWCore/PythonUtilities
FWCore/Skeletons
Utilities/RelMon
Utilities/ReleaseScripts
Utilities/StaticAnalyzers

@perrotta, @smuzaffar, @Dr15Jones, @cmsbuild, @slava77, @santocch can you please review it and eventually sign? Thanks.
@gouskos, @makortel, @cbernet, @wddgit, @Martin-Grunewald, @ahinzmann, @gkasieczka, @drkovalskyi, @hatakeyamak, @gpetruc, @rovere, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34092/console Started: 2019/04/09 20:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26410/34092/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 11, 2019

+1

for #26410 885a056

  • technical
  • jenkins tests pass

@Dr15Jones
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@santocch please check, it looks ok to me, I will move forward with the integration

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 9b226cd into cms-sw:master Apr 11, 2019
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants