New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xrange migration in fwk packages for python3 #26410
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26410/9178
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: DataFormats/FWLite @perrotta, @smuzaffar, @Dr15Jones, @cmsbuild, @slava77, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@santocch please check, it looks ok to me, I will move forward with the integration |
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
at least one unit test in my python3 fwk test fails due to the use of xrange (now range in python3). Migrate using
futurize -f libfuturize.fixes.fix_xrange_with_import -w --no-diffs -n .
(the fwk packages so far)