Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrange migration for python3 #26411

Merged
merged 1 commit into from Apr 12, 2019
Merged

Conversation

davidlange6
Copy link
Contributor

at least one unit test in my python3 fwk test fails due to the use of xrange (now range in python3). Migrate using

futurize -f libfuturize.fixes.fix_xrange_with_import -w --no-diffs -n .

(the physics/reco packages )

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26411/9180

  • This PR adds an extra 436KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

PhysicsTools/Heppy
PhysicsTools/HeppyCore
PhysicsTools/NanoAOD
PhysicsTools/PatAlgos
PhysicsTools/PythonAnalysis
PhysicsTools/TagAndProbe
RecoBTag/PerformanceDB
RecoLuminosity/LumiDB
RecoMET/METFilters
RecoTauTag/Configuration
RecoTauTag/TauTagTools
RecoVertex/BeamSpotProducer

@perrotta, @tocheng, @cmsbuild, @franzoni, @fgolf, @slava77, @ggovi, @pohsun, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @ahinzmann, @mmusich, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @tocheng, @schoef, @ebrondol, @dgulhan, @clelange, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34118/console Started: 2019/04/10 14:00

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26411/34118/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 11, 2019

+1

for #26411 af7a3a7

  • technical
  • jenkins tests pass

@pohsun
Copy link

pohsun commented Apr 11, 2019

+1

@fabiocos
Copy link
Contributor

@santocch @ggovi @fgolf @peruzzim could you please check?

@peruzzim
Copy link
Contributor

+xpog

for the changes in PhysicsTools/NanoAOD

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@santocch @ggovi please have a look anyway and sign it in case for future reference or comment

@cmsbuild cmsbuild merged commit 7965eaa into cms-sw:master Apr 12, 2019
@santocch
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants