New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xrange migration for python3 #26414
xrange migration for python3 #26414
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26414/9183
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Alignment/CommonAlignment @cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test
… On Apr 9, 2019, at 9:40 PM, cmsbuild ***@***.***> wrote:
A new Pull Request was created by @davidlange6 (David Lange) for master.
It involves the following packages:
Alignment/CommonAlignment
Alignment/MillePedeAlignmentAlgorithm
Alignment/MuonAlignment
Alignment/MuonAlignmentAlgorithms
Alignment/OfflineValidation
@cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @abbiendi, @jhgoh, @tocheng, @tlampen, @mschrode, @mmusich, @trocino this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.
cms-bot commands are listed here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
at least one unit test in my python3 fwk test fails due to the use of xrange (now range in python3). Migrate using
futurize -f libfuturize.fixes.fix_xrange_with_import -w --no-diffs -n .
(the alignment packages)