New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced output string on data relvals to avoid exceed length limit #26433
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26433/9214
|
A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for master. It involves the following packages: Configuration/PyReleaseValidation @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Hi @pgunnell, @zhenhu, @prebello, |
Could you pleas put PR description, and the way you do the test? Currently you leave it blank. |
@chayanit thank you. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Done. Let me know if there is anything still missing. |
Can we merge this PR or is there anything still needed to be verified? |
@kpedro88 The signature on upgrade is needed, in case you would like to comment. Thx. |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Due to limit of workflow name (100 characters), we sometimes run into issues of exceed limit and not able to inject some relvals as the workflow name is too long e.g. chayanit_RVCMSSW_10_5_0_pre1_ROOT614RunDisplacedJet2018C__RelVal_displacedJet2018C_190207_102532_234. This PR is made in order to reduce labels on data relvals (bold) as they seem redundant.
PR validation: