Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced output string on data relvals to avoid exceed length limit #26433

Merged
merged 4 commits into from Apr 25, 2019

Conversation

chayanit
Copy link

@chayanit chayanit commented Apr 11, 2019

PR description:

Due to limit of workflow name (100 characters), we sometimes run into issues of exceed limit and not able to inject some relvals as the workflow name is too long e.g. chayanit_RVCMSSW_10_5_0_pre1_ROOT614RunDisplacedJet2018C__RelVal_displacedJet2018C_190207_102532_234. This PR is made in order to reduce labels on data relvals (bold) as they seem redundant.

PR validation:

  1. I have tested by injecting a small set of 2018A relvals here https://dmytro.web.cern.ch/dmytro/cmsprodmon/workflows.php?campaign=CMSSW_10_6_0_pre3__data2018A_testReducedlabel-1554958645. The relvals are successfully done with the reduced string workflow names and output names.
  2. I have also tested with relmon system using "manual" pairing and it works without problem here (https://cms-pdmv.cern.ch/ReleaseMonitoring/Test_Reducedlabel/DataReport/).

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26433/9214

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34154/console Started: 2019/04/11 14:16

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26433/34154/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@chayanit
Copy link
Author

Hi @pgunnell, @zhenhu, @prebello,
could you please review and sign this PR? I have reduced all data strings in order to avoid exceed limits . I have tested by injecting a small set of 2018A relvals here https://dmytro.web.cern.ch/dmytro/cmsprodmon/workflows.php?campaign=CMSSW_10_6_0_pre3__data2018A_testReducedlabel-1554958645. I have also tested with relmon system using "manual" pairing and it seems to work without problem here (https://cms-pdmv.cern.ch/ReleaseMonitoring/Test_Reducedlabel/DataReport/). Let me know if you spot anything unusual. Thanks in advance.
FYI. @srimanob

@srimanob
Copy link
Contributor

Could you pleas put PR description, and the way you do the test? Currently you leave it blank.
@chayanit Thanks.

@prebello
Copy link
Contributor

@chayanit thank you.
I would suggest that you maintain the "nano" in the related wfs (nano_jetHT2018A to nano2018A for instance), the same you did for miniaod case.

@cmsbuild
Copy link
Contributor

Pull request #26433 was updated. @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please check and sign again.

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34251/console Started: 2019/04/17 15:23

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26433/34251/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3142585
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@prebello
Copy link
Contributor

+1

@chayanit
Copy link
Author

chayanit commented Apr 18, 2019

Could you pleas put PR description, and the way you do the test? Currently you leave it blank.
@chayanit Thanks.

Done. Let me know if there is anything still missing.

@chayanit
Copy link
Author

Can we merge this PR or is there anything still needed to be verified?
Cheers,
Chayanit

@srimanob
Copy link
Contributor

@kpedro88 The signature on upgrade is needed, in case you would like to comment. Thx.

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 42f768e into cms-sw:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants