New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 syntax error cleanup #26434
Python3 syntax error cleanup #26434
Conversation
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26434/9220
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: CalibTracker/SiStripESProducers @perrotta, @smuzaffar, @Dr15Jones, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @slava77, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
remove fwk use of atoi (obsolete since python2.0 apparently..)
update more print statements
replace iteritems with six.iteritems
(all things identified by unit test errors in DEVEL build)