Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

710pre3 tracker-lumi geometry #2646

Merged
merged 6 commits into from Feb 28, 2014

Conversation

robervalwalsh
Copy link
Contributor

This request contains new geometry for the tracker to include the lumi detectors PLT and BCM1F. The modifications are available in Geometry/TrackerCommonData/data/test2014 as recommended by the tracker experts.

In addition, the geometries of the lumi detectors, and modifications to make them available, are also included in Geometry/ForwardCommonData.

The modifications only have effect when running the Geometry/CMSCommonData/cmsExtendedGeometryTest2014XML_cfi.py, which is the configuration for the scenario used by the tracker experts for tests.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @robervalwalsh (Roberval Walsh) for CMSSW_7_1_X.

710pre3 tracker-lumi geometry

It involves the following packages:

Geometry/CMSCommonData
Geometry/ForwardCommonData
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2646/302/summary.html

@robervalwalsh
Copy link
Contributor Author

Could you please send me some instructions on how can I run such tests? As the error is the same for all of them I assume that one or two should be enough. I noticed from the log files that the tag CMSSW_7_1_X_2014-02-26-0200 has been used. Is that the recommended one? Thank you.

@civanch
Copy link
Contributor

civanch commented Feb 27, 2014

CMSSW_7_1_X_2014-02-26-0200 is simply the most recent IB. I do not think result is different if you prepared this PR with IB of few days ago.

In your working area you may run it

scram b -jN
runTheMatrix.py -l 4.22

@robervalwalsh
Copy link
Contributor Author

Hi Vladimir,
Thanks. But running the command you suggested I get it fine
4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED - time date Thu Feb 27 12:46:21 2014-date Thu Feb 27 12:42:27 2014; exit: 0 0 0 0 0
1 1 1 1 1 tests passed, 0 0 0 0 0 failed

I am running the other levels with errors to see if they appear for me too. My only doubt is how these relval productions takes the tracker test2014 geometry into account. Maybe that's what is missing for my tests...

Cheers,
Roberval

@robervalwalsh
Copy link
Contributor Author

What I see from log files is that in fact it is Step1 that fails:
4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-FAILED Step2-NOTRUN Step3-NOTRUN Step4-NOTRUN - time date Thu Feb 27 11:31:49 2014-date Thu Feb 27 11:31:41 2014; exit: 0 256 0 0 0

Running runTheMatrix.py -l 4.22 in my working area, what I get from Step1 are two files step1_dasquery.log and step1_lumiRanges.log. The latter gives me the same as in the report sent to me above, whereas the former contains a list of files, while in the report it is empty.

I have the impression it does not have anything to do with the pull request. The errors appear only when running on data. It seems the data was for some reason not found.

If someone has other suggestions for tests please let me know. I would appreciate. For the moment I don't see any problems running from my lxplus account.

Cheers,
Roberval

@civanch
Copy link
Contributor

civanch commented Feb 27, 2014

+1
I have rerun the matrix and tests pass without problems.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Feb 28, 2014
 Geometry -- 710pre3 tracker-lumi geometry
@nclopezo nclopezo merged commit cabe5cd into cms-sw:CMSSW_7_1_X Feb 28, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@robervalwalsh robervalwalsh deleted the my-710pre3-bril-geometry branch September 3, 2015 15:58
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants