Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back DeepBoostedJet V01 #26469

Merged
merged 1 commit into from Apr 22, 2019

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Apr 16, 2019

PR description:

This PR adds back the DeepBoostedJet V01 preprocessing parameter files so it is possible to run the V01 training if needed, as discussed in #26370.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26469/9305

  • This PR adds an extra 16KB to repository

@slava77
Copy link
Contributor

slava77 commented Apr 16, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34228/console Started: 2019/04/16 19:09

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms (Huilin Qu) for master.

It involves the following packages:

RecoBTag/MXNet

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26469/34228/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3142585
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 18, 2019

+1

for #26469 3167274

  • code changes are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no differences
    • the V01 config looks consistent with what was there in the actual V01 (I didn't make an effort to match upper parameter values to a transformed set now named norm_factor)
    • I'm relying on test results in 10_2_X [102X] Update DeepAK8 to 94X training #26370 (comment) which show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dfcf56b into cms-sw:master Apr 22, 2019
@hqucms hqucms deleted the deep-boosted-jets-restore-V01 branch November 15, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants