Fix generation of DTuROSControlData in case of missing FEDs

[battibass]

PR description:

This PR adds the initialisation of the variables within the DTuROSControlData format and and provides a fix for the filling of DTuROSControlData monitoring data within DTuROSRawToDigi.cc.

It was noticed during the first MWGR of 2019 that, in case a FED is missing from the datataking, the DTuROSControlData payload contains twice the information from the FED "before" the missing one (see DQM). The PR addresses this problem.

PR validation:

The same cosmic run was processed with the DT prompt offline analysis programs twice with and without this PR. It was tested that DTuROSControlData is filled properly after the fix and that the fillng of DTDigi information is unaffected by the change.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26479/9332

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @battibass (Carlo Battilana) for master.

It involves the following packages:

DataFormats/DTDigi
EventFilter/DTRawToDigi

@perrotta, @cmsbuild, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34261/console Started: 2019/04/17 20:18

[cmsbuild]

+1
Tested at: ccd0333
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26479/34261/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26479/34261/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3142783
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3142585
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #26479 ccd0333

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no differences (as expected; this is addressing issues only in misconfigured run data processing)

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[battibass]

I've a silly question about backporting. This PR fixes a bug that, among others workflows, affects the Online DQM. In principle it would be good to backport it to whatever release gets used online. I would not ask for a backport only for this fix, but, what are the general plans for release deployment @ P5? Should I prepare a 10_3_X version of this PR?

[boudoul]

Hello @battibass _ I take note of this PR - the Release for next MWGR is not yet decided , it will depend a bit on the readiness of 10_6 (that we may use if ready in time) - We will decide within the next couple of weeks- So I would not start to backport anything at this point, you will be informed (and helped) in due time in case it is needed -

[battibass]

@boudoul thanks for the prompt feedback! I will wait for you to provide further input then.

[fabiocos]

+1