Removed FileInPath::isLocal to avoid user confusion

[Dr15Jones]

Several users thought FileInPath::isLocal would tell them if the file was found at all rather than just stating that the last time the file was found (say in a different job) it was found in the user’s work area. Given this was only used in a couple of places we decided it was better to just remove the method all together and require users to call FileInPath::location() if they wanted to get the same information.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Removed FileInPath::isLocal to avoid user confusion

It involves the following packages:

FWCore/ParameterSet
FWCore/PythonParameterSet

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

+1
This comes from a hypernews discussion
https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3226.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

-1
I ran the usual tests and I found errors in the following unit tests:

---> test TestRunnerFWCoreTFWLiteSelector had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2648/301/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

[ktf]

Unrelated. Merging.