Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing getPayloadData.py script to be able to compile #26484

Merged
merged 1 commit into from Apr 18, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 17, 2019

PR description:

As I pointed out in #26294 (comment) the changes proposed in 3923fdc are breaking the getPayloadData.py script, as it is rolling back the changes introduced in commits e303d9f and a896189.

PR validation:

This command:

getPayloadData.py --plugin pluginTrackerAlignment_PayloadInspector --plot plot_X_BPixBarycenterHistory --tag Alignments --time_type Run --iovs '{"start_iov": "297049", "end_iov": "307082"}' --db sqlite_file:/afs/cern.ch/cms/CAF/CMSALCA/ALCA_TRACKERALIGN/MP/MPproduction/um0001/jobData/jobm/um0001.db --test

executed in CMSSW_10_6_X_2019-04-15-2300 results in:

  File "/cvmfs/cms-ib.cern.ch/nweek-02572/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_6_X_2019-04-15-2300/bin/slc7_amd64_gcc700/getPayloadData.py", line 222
    print ''
           ^
SyntaxError: invalid syntax

while it works with this fix.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26484/9339

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 17, 2019

type bug-fix

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34264/console Started: 2019/04/17 22:31

@fabiocos
Copy link
Contributor

@mmusich thanks, anyway I had checked the compilation and funnily it does not show problems, as also seen in the IB...

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26484/34264/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3142585
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Apr 18, 2019

anyway I had checked the compilation and funnily it does not show problems, as also seen in the IB...

@fabiocos, I am not sure where to check about the python scripts compilation but if I use this rather innocent set of commands:

cmsrel CMSSW_10_6_X_2019-04-17-2300
cd CMSSW_10_6_X_2019-04-17-2300/src/
cmsenv
getPayloadData.py --help

I still get:

  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw/CMSSW_10_6_X_2019-04-17-2300/bin/slc7_amd64_gcc820/getPayloadData.py", line 222
    print ''

@fabiocos
Copy link
Contributor

@mmusich I was referring to https://github.com/cms-sw/cms-bot/blob/master/run-ib-python3#L13 that we are regularly running. Anyway this is ok to go

@fabiocos
Copy link
Contributor

+1

@ggovi the due fix is purely technical, and missed the original submission. Please check, sign it for future reference or update it further

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 8c0b3de into cms-sw:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants