Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all EgammaAnalysis packages except for ElectronTools #26488

Merged
merged 1 commit into from Apr 25, 2019
Merged

Removed all EgammaAnalysis packages except for ElectronTools #26488

merged 1 commit into from Apr 25, 2019

Conversation

guitargeek
Copy link
Contributor

PR description:

As I have seen on the egamma meeting at the last CMS week, one of the plans is to get rid of some old ID code. Why not start here with these old skims and IDs? Are there used for anything @Sam-Harper?

PR validation:

Code compiles and matrix tests pass.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26488/9343

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

EgammaAnalysis/CSA07Skims
EgammaAnalysis/Configuration
EgammaAnalysis/ElectronIDESSources
EgammaAnalysis/PhotonIDProducers
Utilities/ReleaseScripts

@cmsbuild, @smuzaffar, @Dr15Jones, @santocch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @jainshilpi, @Sam-Harper, @varuns23, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Sam-Harper
Copy link
Contributor

I'm totally fine with this :D Thanks Jonas :)

"EgammaAnalysis/Configuration", "EgammaAnalysis/ElectronIDESSources",
"EgammaAnalysis/PhotonIDProducers", "ElectroWeakAnalysis/Configuration",
"DiffractiveForwardAnalysis/Skimming",
"ElectroWeakAnalysis/Configuration",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to recall that this file is supposed to contain all known packages from the past, not just the current release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? I did the same thing in another PR where I removed a package:
#26186
Back then, @Dr15Jones was giving a +1 for that. So maybe I should also revert that change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, I may have misunderstood/confused with another file with a list of packages.
This one is in the core signautre list anyways and will be confirmed.

@slava77
Copy link
Contributor

slava77 commented Apr 17, 2019

@Sam-Harper
please confirm that the removal is OK for the POG needs.

@Sam-Harper
Copy link
Contributor

Indeed it is fine by me. If anybody is actually using it, we can always recover it from git. However I very much doubt it.

In general, there is going to be a lot more of this happening for 11_X, I want to remove as much code as possible, erring on the side of removing when in doubt as we can always add it back in later.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34274/console Started: 2019/04/18 14:32

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26488/34274/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26488/29034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3213660
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3213455
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@santocch
Copy link

+1

@Dr15Jones
Copy link
Contributor

+1
for Utilities/ReleaseScripts

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bcb562a into cms-sw:master Apr 25, 2019
@guitargeek guitargeek deleted the EgmmaAnalysis_keep_only_ElectronTools branch April 25, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants