Run2-hcx195 Remove direct CLHEP reference in the algorithm for HCAL endcap #26491

bsunanda · 2019-04-17T21:27:29Z

PR description:

Remove direct reference to CLHEP in all the algorithms - the last ones related to HCAL endocarps

PR validation:

Standard runTheMatrix.py works fine

if this PR is a backport please specify the original PR:

Meant for master and no back porting is needed

cmsbuild · 2019-04-17T21:28:05Z

The code-checks are being triggered in jenkins.

bsunanda · 2019-04-17T21:31:44Z

@cmsbuild Please test

cmsbuild · 2019-04-17T21:34:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26491/9349

This PR adds an extra 32KB to repository

cmsbuild · 2019-04-17T21:35:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34267/console Started: 2019/04/17 23:35

cmsbuild · 2019-04-17T21:35:06Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HcalAlgo

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-04-17T21:36:26Z

There was an issue with git-cms-merge-topic you can see the log here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26491/34267/git-merge-result

bsunanda · 2019-04-18T15:58:35Z

@cmsbuild Please test

cmsbuild · 2019-04-18T15:59:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34277/console Started: 2019/04/18 17:59

cmsbuild · 2019-04-18T17:23:40Z

-1

Tested at: 1ffa319

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26491/34277/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step2

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Thu Apr 18 19:09:08 2019-date Thu Apr 18 19:03:05 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_6_X_2019-04-17-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 18 19:09:08 2019-date Thu Apr 18 19:03:05 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Apr 18 19:09:08 2019-date Thu Apr 18 19:03:05 2019 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_6_X_2019-04-17-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Thu Apr 18 19:04:06 2019-date Thu Apr 18 19:03:19 2019 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Thu Apr 18 19:07:51 2019-date Thu Apr 18 19:03:22 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_6_X_2019-04-17-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 18 19:07:51 2019-date Thu Apr 18 19:03:22 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Thu Apr 18 19:07:51 2019-date Thu Apr 18 19:03:22 2019 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Thu Apr 18 19:10:52 2019-date Thu Apr 18 19:04:16 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_6_X_2019-04-17-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Apr 18 19:10:52 2019-date Thu Apr 18 19:04:16 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Apr 18 19:10:52 2019-date Thu Apr 18 19:04:16 2019 s - exit: 21504

cmsbuild · 2019-04-18T17:23:45Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

bsunanda · 2019-04-18T21:02:37Z

The errors seem not due to this PR. This PR affects geometry and failures are in Trigger jobs

bsunanda · 2019-04-18T21:02:52Z

@cmsbuild Please test

cmsbuild · 2019-04-18T21:03:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34282/console Started: 2019/04/18 23:05

cmsbuild · 2019-04-18T22:36:38Z

+1
Tested at: 1ffa319
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26491/34282/summary.html

cmsbuild · 2019-04-18T22:36:43Z

Comparison job queued.

cmsbuild · 2019-04-19T00:07:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26491/34282/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26491/29034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3213660
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3213455
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

cvuosalo · 2019-04-19T23:24:30Z

+1

cmsbuild · 2019-04-19T23:25:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-04-22T10:34:54Z

+1

Remove direct CLHEP reference in the algorithm for HCAL endcap

1ffa319

cmsbuild added this to the CMSSW_10_6_X milestone Apr 17, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Apr 17, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 17, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 17, 2019

cmsbuild added tests-pending and removed tests-started labels Apr 18, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 18, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Apr 18, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Apr 18, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 18, 2019

cmsbuild added tests-approved and removed tests-started labels Apr 18, 2019

cmsbuild added comparison-available and removed comparison-pending labels Apr 19, 2019

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Apr 19, 2019

cmsbuild added orp-approved and removed orp-pending labels Apr 22, 2019

cmsbuild merged commit f57b4f3 into cms-sw:master Apr 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run2-hcx195 Remove direct CLHEP reference in the algorithm for HCAL endcap #26491

Run2-hcx195 Remove direct CLHEP reference in the algorithm for HCAL endcap #26491

bsunanda commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

bsunanda commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

cmsbuild commented Apr 17, 2019 •

edited

cmsbuild commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

bsunanda commented Apr 18, 2019

cmsbuild commented Apr 18, 2019 •

edited

cmsbuild commented Apr 18, 2019

cmsbuild commented Apr 18, 2019

bsunanda commented Apr 18, 2019

bsunanda commented Apr 18, 2019

cmsbuild commented Apr 18, 2019 •

edited

cmsbuild commented Apr 18, 2019

cmsbuild commented Apr 18, 2019

cmsbuild commented Apr 19, 2019

cvuosalo commented Apr 19, 2019

cmsbuild commented Apr 19, 2019

fabiocos commented Apr 22, 2019

Run2-hcx195 Remove direct CLHEP reference in the algorithm for HCAL endcap #26491

Run2-hcx195 Remove direct CLHEP reference in the algorithm for HCAL endcap #26491

Conversation

bsunanda commented Apr 17, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Apr 17, 2019

bsunanda commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

cmsbuild commented Apr 17, 2019 • edited

cmsbuild commented Apr 17, 2019

cmsbuild commented Apr 17, 2019

bsunanda commented Apr 18, 2019

cmsbuild commented Apr 18, 2019 • edited

cmsbuild commented Apr 18, 2019

cmsbuild commented Apr 18, 2019

bsunanda commented Apr 18, 2019

bsunanda commented Apr 18, 2019

cmsbuild commented Apr 18, 2019 • edited

cmsbuild commented Apr 18, 2019

cmsbuild commented Apr 18, 2019

cmsbuild commented Apr 19, 2019

cvuosalo commented Apr 19, 2019

cmsbuild commented Apr 19, 2019

fabiocos commented Apr 22, 2019

cmsbuild commented Apr 17, 2019 •

edited

cmsbuild commented Apr 18, 2019 •

edited

cmsbuild commented Apr 18, 2019 •

edited