Pixel Phase-1 material budget classification

[zucchett]

PR description:

This PR updates the classification of the pixel material budget to the new materials introduced in the Phase-1 pixel simulation. This PR does not change neither the geometry nor the total material budget. This PR finalizes the material classification performed in the Validation/ package used to produce the material budget plots, and these plots are the only parts affected by this PR. The new plots, produced after the modification included in this PR, have been already approved and made public in CMS DP-2019/006.

PR validation:

The tests recommended in the PRWorkflow page have been run successfully, including runTheMatrix.py.

PR documentation

The presentations to the Tracker DPG group supporting this PR can be found here:

https://indico.cern.ch/event/787556/contributions/3273998/attachments/1779074/2893599/190115_Zucchetta.pdf

https://indico.cern.ch/event/787654/contributions/3298227/attachments/1786961/2909823/190129_Zucchetta.pdf

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26516/9379

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @zucchett (Alberto Zucchetta) for master.

It involves the following packages:

Validation/Geometry

@andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks.
@vargasa, @rishabhCMS, @rovere, @rbartek this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34311/console Started: 2019/04/24 00:29

[cmsbuild]

-1

Tested at: 8888444

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26516/34311/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26516/9385

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #26516 was updated. @andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @civanch can you please check and sign again.

[zucchett]

@vargasa The PR description has been updated with the links to the two presentations describing the changes introduced in this PR

[vargasa]

@zucchett Thanks for looking into this

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34330/console Started: 2019/04/24 20:31

[cmsbuild]

+1
Tested at: bff2694
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26516/34330/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26516/34330/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[andrius-k]

+1

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1