Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DigiToRaw to Tasks #26527

Merged
merged 1 commit into from May 1, 2019
Merged

Migrate DigiToRaw to Tasks #26527

merged 1 commit into from May 1, 2019

Conversation

makortel
Copy link
Contributor

PR description:

This PR migrates DigiToRaw step to use Tasks in the configuration. This change should increase the available concurrency in the jobs running DigiToRaw.

PR validation:

Limited matrix runs.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26527/9399

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/StandardSequences
EventFilter/HcalRawToDigi
EventFilter/L1TRawToDigi
L1Trigger/Configuration

@perrotta, @cmsbuild, @rekovic, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @thomreis, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34332/console Started: 2019/04/24 23:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26527/34332/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

+1

  • Technical: migration from Sequences to Tasks is implemented as proposed in the PR description
  • Jenkins tests pass and show no differences

@fabiocos
Copy link
Contributor

+operations

the StandardSequence configurations update looks coherent with the purpose of the PR

@fabiocos
Copy link
Contributor

@rekovic could you please have a look?

@fabiocos
Copy link
Contributor

@rekovic ping

@fabiocos
Copy link
Contributor

fabiocos commented May 1, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 1, 2019

merge

@rekovic please check and comment in case

@cmsbuild cmsbuild merged commit d3308f3 into cms-sw:master May 1, 2019
@rekovic
Copy link
Contributor

rekovic commented May 2, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants