Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonTools/MVAUtils clang-format and merge plugins .h and .cc files #26529

Merged
merged 2 commits into from Apr 27, 2019
Merged

CommonTools/MVAUtils clang-format and merge plugins .h and .cc files #26529

merged 2 commits into from Apr 27, 2019

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Apr 25, 2019

PR description:

I applied clang-format to the CommonTools/MVAUtils package.

Additionally, I took the advantage of merging the .h and .cc file of the (single) plugin in that package as recommended by the new CMSSW code guidelines.

PR validation:

code compiles.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26529/9403

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CommonTools/MVAUtils

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Apr 25, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34342/console Started: 2019/04/25 16:12

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26529/34342/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 25, 2019

@guitargeek
please update the PR title and description to reflect changes in 6d83484

@guitargeek guitargeek changed the title CommonTools/MVAUtils clang-format CommonTools/MVAUtils clang-format and merge plugins .h and .cc files Apr 25, 2019
@slava77
Copy link
Contributor

slava77 commented Apr 25, 2019

+1

for #26529 6d83484

  • code changes are in line with the PR description and the follow up review
  • jenkins tests pass and comparisons with the baseline show no differences as expected for the technical updates

@fabiocos
Copy link
Contributor

+1

technical update

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 2d62c0a into cms-sw:master Apr 27, 2019
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@guitargeek guitargeek deleted the CommonTools_MVAUtils_clang_format branch May 20, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants