New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommonTools/MVAUtils clang-format and merge plugins .h and .cc files #26529
CommonTools/MVAUtils clang-format and merge plugins .h and .cc files #26529
Conversation
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26529/9403
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: CommonTools/MVAUtils @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@guitargeek |
+1 for #26529 6d83484
|
+1 technical update |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
I applied clang-format to the CommonTools/MVAUtils package.
Additionally, I took the advantage of merging the
.h
and.cc
file of the (single) plugin in that package as recommended by the new CMSSW code guidelines.PR validation:
code compiles.