PPS: crash prevention in proton reconstruction

[jan-kaspar]

PR description:

This is a technical PR aiming at improved stability of PPS proton reconstruction. The code currently in master could possibly pass NaN to TSpline3::Eval which would throw an exception (cf. this report CTPPS#38). The proposed fix ensures that NaN are not passed to the Eval method.

PR validation:

Below a comparison of several proton-reconstruction quantities and for several periods. Blue: with this PR, red dashed: before this PR. There is no difference.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26530/9406

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

RecoCTPPS/ProtonReconstruction

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@forthommel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jan-kaspar]

I've run the AddOn tests, yielding 47 tests passed, 0 failed. Could someone trigger tests, please?

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34341/console Started: 2019/04/25 14:41

[cmsbuild]

+1
Tested at: a100bf8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26530/34341/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26530/34341/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #26530 a100bf8

• code changes are in line with the PR description (changes include reasonable protections against divisions by 0 , sqrt of negative values and alike).
• jenkins tests pass and comparisons with the baseline show no differences, indicating that the issue is not widespread.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1