Run3-gem31 Change GEMDetId in view of merging ME0 with GE1/2 #26538

bsunanda · 2019-04-25T16:26:48Z

PR description:

ME0 also contains GEM detectors like in GE11 and GE21. Attempt to merge the 2 DetID's ME0DetId and GEMDetId. GEMDetId will be used in all future applications

PR validation:

Standard runTheMatrix.py is run to test the changes. Also a file created in earlier production is read in with the changed GEMDetId class and tested to yield the same results

if this PR is a backport please specify the original PR:

No back porting is needed. However any change in DetId class needs recompilation a large part of the CMSSW code

cmsbuild · 2019-04-25T16:27:25Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-25T16:32:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26538/9423

This PR adds an extra 20KB to repository

cmsbuild · 2019-04-25T16:33:31Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

DataFormats/MuonDetId

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@battibass, @trocino, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @ptcox, @rovere, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2019-04-25T16:48:50Z

@cmsbuild Please test

cmsbuild · 2019-04-25T16:49:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34348/console Started: 2019/04/25 18:50

cmsbuild · 2019-04-25T21:02:44Z

-1

Tested at: 8d6731a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26538/34348/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

11624.0 step2

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

cmsbuild · 2019-04-25T21:02:49Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2019-04-25T22:54:14Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-25T22:59:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26538/9432

This PR adds an extra 20KB to repository

cmsbuild · 2019-05-30T08:29:53Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #26944
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/600/console Started: 2019/05/30 10:32

cmsbuild · 2019-05-30T11:14:00Z

+1
Tested at: dbcca7b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2c55a/600/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6896932
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26538/600/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26538/600/git-merge-result

cmsbuild · 2019-05-30T11:14:09Z

Comparison job queued.

cmsbuild · 2019-05-30T12:50:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2c55a/600/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 15 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3210728
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3210393
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

kpedro88 · 2019-05-30T17:54:11Z

There are still a few differences in the reco comparisons. Are these expected?

slava77 · 2019-05-30T18:11:41Z

There are still a few differences in the reco comparisons. Are these expected?

these are false-positives.
The comparison script loads the old file first, which leads to incorrect reading of the new one GEM.

kpedro88 · 2019-05-30T18:13:27Z

+upgrade

bsunanda · 2019-05-31T16:15:26Z

@civanch Please approve this PR

civanch · 2019-05-31T18:20:38Z

+1

cmsbuild · 2019-05-31T18:21:17Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-04T08:30:07Z

+1

cmsbuild added this to the CMSSW_10_6_X milestone Apr 25, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Apr 25, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 25, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 25, 2019

cmsbuild added comparison-notrun tests-rejected code-checks-pending comparison-pending tests-pending and removed comparison-pending tests-started code-checks-approved comparison-notrun tests-rejected labels Apr 25, 2019

cmsbuild added comparison-pending tests-pending labels May 30, 2019

cmsbuild mentioned this pull request May 30, 2019

Run3-gem33 Fix GEMGeometry to allow DetId transition #26944

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels May 30, 2019

cmsbuild added tests-approved and removed tests-started labels May 30, 2019

cmsbuild added comparison-available and removed comparison-pending labels May 30, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels May 30, 2019

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels May 31, 2019

cmsbuild added orp-approved and removed orp-pending labels Jun 4, 2019

cmsbuild merged commit 827b691 into cms-sw:master Jun 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gem31 Change GEMDetId in view of merging ME0 with GE1/2 #26538

Run3-gem31 Change GEMDetId in view of merging ME0 with GE1/2 #26538

bsunanda commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

bsunanda commented Apr 25, 2019

cmsbuild commented Apr 25, 2019 •

edited

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

cmsbuild commented May 30, 2019 •

edited

cmsbuild commented May 30, 2019

cmsbuild commented May 30, 2019

cmsbuild commented May 30, 2019

kpedro88 commented May 30, 2019

slava77 commented May 30, 2019

kpedro88 commented May 30, 2019

bsunanda commented May 31, 2019

civanch commented May 31, 2019

cmsbuild commented May 31, 2019

fabiocos commented Jun 4, 2019

Run3-gem31 Change GEMDetId in view of merging ME0 with GE1/2 #26538

Run3-gem31 Change GEMDetId in view of merging ME0 with GE1/2 #26538

Conversation

bsunanda commented Apr 25, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

bsunanda commented Apr 25, 2019

cmsbuild commented Apr 25, 2019 • edited

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

cmsbuild commented Apr 25, 2019

cmsbuild commented May 30, 2019 • edited

cmsbuild commented May 30, 2019

cmsbuild commented May 30, 2019

cmsbuild commented May 30, 2019

kpedro88 commented May 30, 2019

slava77 commented May 30, 2019

kpedro88 commented May 30, 2019

bsunanda commented May 31, 2019

civanch commented May 31, 2019

cmsbuild commented May 31, 2019

fabiocos commented Jun 4, 2019

cmsbuild commented Apr 25, 2019 •

edited

cmsbuild commented May 30, 2019 •

edited