Devel dqm offline trigger top #26540
Conversation
…nditions_2017 modifiers
… DeepCSV discr is selected.
…e eras). Should be fixed in the next PR
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26540/9427
|
|
A new Pull Request was created by @skonstantinou for master. It involves the following packages: DQMOffline/Trigger @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Pull request #26540 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
| from Configuration.Eras.Modifier_run2_muon_2017_cff import run2_muon_2017 | ||
| from Configuration.Eras.Modifier_run2_muon_2016_cff import run2_muon_2016 | ||
|
|
||
| Run2_2017 = cms.ModifierChain(Run2_2016.copyAndExclude([run2_muon_2016]), | ||
| Run2_2017 = cms.ModifierChain(Run2_2016.copyAndExclude([run2_muon_2016, run2_HLTconditions_2016]), |
There was a problem hiding this comment.
@skonstantinou could you please clarify the purpose of this modification? Add a piece to drop it.
There was a problem hiding this comment.
The run2_HLTcondition_2016 was contained in Run2_2018 and Run2_2017 and thus it was always selected, even when using the Run2_2017 or Run2_2018 era option. The problem is solved by removing the run2_HLTconditions_2016 modifier from Run2_2017 and run2_HLTconditions_2017 from Run2_2018 with this modification (similarly to what was done in #26489).
| from Configuration.Eras.Modifier_run2_muon_2018_cff import run2_muon_2018 | ||
| from Configuration.Eras.Modifier_run2_muon_2017_cff import run2_muon_2017 | ||
| from Configuration.Eras.Modifier_run2_L1prefiring_cff import run2_L1prefiring | ||
|
|
||
| Run2_2018 = cms.ModifierChain(Run2_2017.copyAndExclude([run2_HEPlan1_2017, run2_muon_2017, run2_L1prefiring]), | ||
| Run2_2018 = cms.ModifierChain(Run2_2017.copyAndExclude([run2_HEPlan1_2017, run2_muon_2017, run2_L1prefiring, run2_HLTconditions_2017]), |
There was a problem hiding this comment.
@skonstantinou same comment here
|
+operations the update of Eras is coherent with the purpose of the PR |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
operations-approved
and removed
operations-pending
pending-signatures
labels
|
+1 |
…backport updates to Top-HLT sequence in DQMOffline (backport of #26540)
PR description:
Added Run2_HLTconditions_2016, Run2_HLTconditions_2017, Run2_HLTconditions_2018 modifiers in TopMonitor to select the correct HLT paths and b-tagging algorithm for each era. Some empty plots due to missing paths are expected when running 2016 datasets. A new cms sequence for 2016 will be added to fix the problem.
PR validation:
The code has been tested with runTheMatrix.py -l 10024.0 and by running on 2017, 2018 datasets
@sscruz @missirol