Phase 2 Trackers. Remove T12 and T13 (IT portcards placement study). Add T15 (Major Inner Tracker MB update from latest Mechanical designs). #26544

ghugo83 · 2019-04-26T12:35:38Z

PR description:

This PR adds Tracker T15, and its associated workflows.
This Tracker has same active geometry as T14, but significant MB update from latest Mechanical designs. More details in [1].
Thanks a lot to IT Mechanics group for the fruitful exchange!

Full Tracker description is accessible at: http://ghugo.web.cern.ch/ghugo/layouts/T15/OT616_200_IT613/info.html

Geometry scenario is: 2023D42.
Workflows are: 294xx (no PU), 296xx (PU).

Tracking performance should be compared with T14 (2023D40 scenario).
Notably, it would be valuable to get the fake rate at PU200 (workflow 29434.0) versus T14.

This PR also removes the Trackers which were used for IT portcards placement study (T12 and T13 + their associated workflows).

NB: This includes data from latest Mechanical designs, which is a moving process: obviously IT MB will still need to be further updated, as latest designs become available. This can imply significant changes.
This PR does however contain a first deep review of full IT MB.
This should also point out the importance of Mechanical choices, which can have a deep impact on the tracking performance.

PR validation:
Following was done for validation:

Deep debug with Mechanical engineers, often data needed to be adapted to be in a format which tkLayout can digest.
Debug / adaptation of tkLayout for new IT MB, all volumes.
Debug of XMLs, all volumes.
Solved all overlaps on CMSSW with Fireworks and Geant4 tools.
Checked no shift in workflows numbers.
Checked that workflows with D42 run smoothly with no extra error / warning.

[1] Tracker changes in this PR (versus T14 description):

Outer Tracker:
Slight diff in MB, intentionally kept to non-significant.

Inner Tracker:

Module materials fully revisited: HDI, capacitors, ROC.
Added missing/updated modules cooling rails and cooling blocks materials.
Cooling pipes fully revisited, for all subdetectors: Ti -> SS everywhere, 1 mm wall thickness everywhere, changed diameters and #pipes in TBPX, changed to double-pass model in TFPX and TEPX, adaptation to new dee design in TEPX.
TEPX: also added PCB panel.
Added missing supports and screws, updated CFRP supports thicknesses.
ITST and service cylinder fully revisited: geometry, materials, also added flange section and reinforcement rings.
Cabling updated to latest designs.

TO DO:

Portcards not updated.
Add junction interface (CFRP) between TBPX outer cylinder and services cylinder.
All cooling pipes diameters are set in tkLayout to ID=2.0 mm and OD = 2.2 mm (except on TBPX ladders: ID = 1.6 mm and OD = 1.8 mm). To be tuned.
Add ITST support rails.
Further tune ITST & service cylinder.
Add to tkLayout software support for more precise volume description and placement (many points here!).
Services are assumed to be uniformly distributed around service cylinder, instead of routed at specific phi locations.
OT MB not revised.

FYI: @emiglior @jalimena @boudoul @kpedro88 @pwittich @alkemyst

… geometry same as T14). + Remove XMLs from T12 and T13.

…rs T12 and T13 respectively).

…ws associated to D36 and D37 geometry scenarios. Made workflow numbering invariant.

cmsbuild · 2019-04-26T12:36:14Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-26T12:42:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26544/9440

This PR adds an extra 180KB to repository

cmsbuild · 2019-04-26T12:42:42Z

A new Pull Request was created by @ghugo83 for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData

@cmsbuild, @prebello, @Dr15Jones, @cvuosalo, @civanch, @ianna, @mdhildreth, @pgunnell, @franzoni, @kpedro88, @zhenhu, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2019-04-26T14:26:07Z

please test workflow 29434.0

cmsbuild · 2019-04-26T14:26:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34365/console Started: 2019/04/26 16:27

cmsbuild · 2019-04-26T17:27:50Z

+1
Tested at: 6533b96
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26544/34365/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6533b96
90d4f3d
476b14c
a9ec3bd
c0c6189
01cf38a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26544/34365/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26544/34365/git-merge-result

cmsbuild · 2019-04-26T17:27:55Z

Comparison job queued.

cmsbuild · 2019-04-26T19:03:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26544/34365/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26544/29434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D42_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D42+RecoFullGlobal_2023D42+HARVESTFullGlobal_2023D42

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3211964
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211759
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

cmsbuild · 2019-04-29T17:50:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26544/34404/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26544/29434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D42_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D42+RecoFullGlobal_2023D42+HARVESTFullGlobal_2023D42

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3211964
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211759
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

kpedro88 · 2019-04-30T14:46:46Z

+upgrade

cvuosalo · 2019-04-30T21:24:58Z

+1

fabiocos · 2019-05-02T12:51:28Z

+operations

the update of Configuration packages is coherent with the purpose of the PR

fabiocos · 2019-05-02T12:52:34Z

@ghugo83 @emiglior out of curiosity, this new D42 scenario is not including any BTL. Is this a realistic option?

fabiocos · 2019-05-02T12:53:20Z

@zhenhu @prebello could you please check and sign or comment? The addition of tests for the new scenario looks ok

kpedro88 · 2019-05-02T15:13:49Z

@fabiocos I also noticed this new scenario includes very old versions of other Phase 2 subdetectors. I think this is done to be consistent with other tracker test scenarios for comparisons. But I agree, at some point (11_0_X?), we should move every scenario toward the more recent configurations.

fabiocos · 2019-05-04T19:27:59Z

@prebello @zhenhu ping

ghugo83 · 2019-05-06T08:39:14Z

Hi @fabiocos @kpedro88 Yes exactly, the idea here is to compare with other versions of the Inner Tracker, so updating other things in parallel in the same PR can be misleading.
The other sub detectors should be updated at some point tough, but consistently and for all scenarios.

fabiocos · 2019-05-06T09:41:28Z

@prebello @zhenhu ping again, unless you have an issue with this PR I would like to move forward with it asap

fabiocos · 2019-05-07T08:20:38Z

@prebello @zhenhu the code looks ok to me, I will merge it, in case please either sign it for future reference or comment and propose further updates

fabiocos · 2019-05-07T08:44:26Z

+1

fabiocos · 2019-05-07T08:44:38Z

merge

prebello · 2019-05-07T14:32:17Z

+1

cmsbuild · 2019-05-07T14:33:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

ghugo83 added 4 commits April 26, 2019 11:10

XMLs: Add T15: Major Inner Tracker MB update, 2019 04 (Tracker active…

d9ad836

… geometry same as T14). + Remove XMLs from T12 and T13.

Geometry scenarios: Add D42 (Tracker T15). Remove D36 and D37 (Tracke…

c4a0d9a

…rs T12 and T13 respectively).

Workflows. Add workflow for D42 geometry scenario. Remove all workflo…

ef5bf9b

…ws associated to D36 and D37 geometry scenarios. Made workflow numbering invariant.

Merge latest official-cmssw/master, fixed merge conflict.

6533b96

cmsbuild added this to the CMSSW_10_6_X milestone Apr 26, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Apr 26, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 26, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 26, 2019

cmsbuild added tests-approved and removed tests-started labels Apr 26, 2019

cmsbuild added comparison-available and removed comparison-pending labels Apr 26, 2019

cmsbuild added comparison-available and removed comparison-pending labels Apr 29, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels Apr 30, 2019

cmsbuild added geometry-approved and removed geometry-pending labels Apr 30, 2019

cmsbuild added operations-approved and removed operations-pending labels May 2, 2019

cmsbuild added orp-approved and removed orp-pending labels May 7, 2019

cmsbuild merged commit da2a03f into cms-sw:master May 7, 2019

cmsbuild added fully-signed pdmv-approved and removed pdmv-pending pending-signatures labels May 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase 2 Trackers. Remove T12 and T13 (IT portcards placement study). Add T15 (Major Inner Tracker MB update from latest Mechanical designs). #26544

Phase 2 Trackers. Remove T12 and T13 (IT portcards placement study). Add T15 (Major Inner Tracker MB update from latest Mechanical designs). #26544

ghugo83 commented Apr 26, 2019 •

edited

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

kpedro88 commented Apr 26, 2019

cmsbuild commented Apr 26, 2019 •

edited

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 29, 2019

kpedro88 commented Apr 30, 2019

cvuosalo commented Apr 30, 2019

fabiocos commented May 2, 2019

fabiocos commented May 2, 2019

fabiocos commented May 2, 2019

kpedro88 commented May 2, 2019

fabiocos commented May 4, 2019

ghugo83 commented May 6, 2019

fabiocos commented May 6, 2019

fabiocos commented May 7, 2019

fabiocos commented May 7, 2019

fabiocos commented May 7, 2019

prebello commented May 7, 2019

cmsbuild commented May 7, 2019

Phase 2 Trackers. Remove T12 and T13 (IT portcards placement study). Add T15 (Major Inner Tracker MB update from latest Mechanical designs). #26544

Phase 2 Trackers. Remove T12 and T13 (IT portcards placement study). Add T15 (Major Inner Tracker MB update from latest Mechanical designs). #26544

Conversation

ghugo83 commented Apr 26, 2019 • edited

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

kpedro88 commented Apr 26, 2019

cmsbuild commented Apr 26, 2019 • edited

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 29, 2019

kpedro88 commented Apr 30, 2019

cvuosalo commented Apr 30, 2019

fabiocos commented May 2, 2019

fabiocos commented May 2, 2019

fabiocos commented May 2, 2019

kpedro88 commented May 2, 2019

fabiocos commented May 4, 2019

ghugo83 commented May 6, 2019

fabiocos commented May 6, 2019

fabiocos commented May 7, 2019

fabiocos commented May 7, 2019

fabiocos commented May 7, 2019

prebello commented May 7, 2019

cmsbuild commented May 7, 2019

ghugo83 commented Apr 26, 2019 •

edited

cmsbuild commented Apr 26, 2019 •

edited