Remove constructors taking CSCDMBStatusDigi from CSCDMBHeader and CSCDMBTrailer

[makortel]

PR description:

CSCDMBHeader and CSCDMBTrailer both have a constructor taking CSCDMBStatusDigi and doing a memcpy(this, ...) from it. The problem is that both CSCDMBHeader and CSCDMBTrailer have a boost::shared_ptr as their first member, and it makes no sense to overwrite those via a memcpy. These constructors are not called (anymore?) in CMSSW, and judging from the git history it looks like they could be leftovers from #4034. This PR suggests to remove these constructors.

This issue was found by GCC 9.

In addition this PR replaces the boost::shared_ptr's with std::shared_ptr in these two classes, and makes the dynamic_casts const-correct.

PR validation:

The code compiles without warnings with GCC 9.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26552/9452

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

EventFilter/CSCRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34373/console Started: 2019/04/26 21:35

[cmsbuild]

+1
Tested at: 84e59ea
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26552/34373/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26552/34373/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• Those constructors with CSCDMBStatusDigi as argument are indeed never used in CMSSW, and they can be safely removed
• As such, this is a technical pull request, with no effect on jenkins tests output

[perrotta]

@ptcox FYI

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1