Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not Merge] Apply readability-braces-around-statements clang-tidy check for Alignment #26563

Closed
wants to merge 2 commits into from
Closed

[Do not Merge] Apply readability-braces-around-statements clang-tidy check for Alignment #26563

wants to merge 2 commits into from

Conversation

smuzaffar
Copy link
Contributor

PR description:

Please do not merge. This PR is to tests clang-tidy check readability-braces-around-statements. This should be tested along with #21478 and cms-sw/cmsdist#4914

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26563/9474

  • This PR adds an extra 1208KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Alignment/APEEstimation
Alignment/CocoaApplication
Alignment/CocoaFit
Alignment/CocoaModel
Alignment/CocoaToDDL
Alignment/CocoaUtilities
Alignment/CommonAlignment
Alignment/CommonAlignmentAlgorithm
Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentParametrization
Alignment/CommonAlignmentProducer
Alignment/Geners
Alignment/HIPAlignmentAlgorithm
Alignment/LaserAlignment
Alignment/LaserAlignmentSimulation
Alignment/LaserDQM
Alignment/MillePedeAlignmentAlgorithm
Alignment/MuonAlignment
Alignment/MuonAlignmentAlgorithms
Alignment/OfflineValidation
Alignment/ReferenceTrajectories
Alignment/SurveyAnalysis
Alignment/TrackerAlignment
Alignment/TwoBodyDecay

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @abbiendi, @jhgoh, @tocheng, @tlampen, @mschrode, @mmusich, @trocino this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test with #21478 cms-sw/cmsdist#4914

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#4914,#21478
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34400/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26563/34400/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26563/9489

  • This PR adds an extra 2020KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@smuzaffar smuzaffar closed this Apr 30, 2019
@smuzaffar smuzaffar reopened this May 2, 2019
@smuzaffar
Copy link
Contributor Author

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2019

The code-checks are being triggered in jenkins.

@smuzaffar smuzaffar closed this May 2, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26563/9523

  • This PR adds an extra 3748KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants