New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making filling conversion vtx fit prob optional #26567
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26567/9480
|
A new Pull Request was created by @Sam-Harper (Sam Harper) for master. It involves the following packages: RecoEgamma/EgammaElectronAlgos @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bugfix |
@cmsbuild please test workflow 140.55 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 for #26567 739068e
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 @Sam-Harper thanks for the prompt reaction |
PR description:
Fixes issue raised here #26562
This makes filling the conversion vertex fit probability optional for GsfElectrons. HION doesnt have conversions and thus has issues here. So added a simple flag to disable it for cases like this rather than having to run the conversion workflow in HION.