PPS: fix in proton reconstruction

[jan-kaspar]

PR description:

This PR provides a fix to a bug which sometimes prevented saving single-RP results due to a misplaced "continue" statement in the multi-RP reconstruction block.

PR validation:

Below a comparison of several histograms of proton-reconstruction quantities, where

• blue: with this PR
• red dashed: before this PR

The only difference can be seen in the 1st and 5th column - showing single-RP results. As expected, the blue histograms are always larger than the red ones - additional evens are recuperated. All other columns are related to multi-RP reconstruction, not affected by the bug neither this fix.

[cmsbuild]

The code-checks are being triggered in jenkins.

[jan-kaspar]

@fabferro @vavati FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26568/9481

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

RecoCTPPS/ProtonReconstruction

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@forthommel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jan-kaspar]

I've run the addOn tests, yielding 47 tests passed, 0 failed. Could some trigger tests please?

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34408/console Started: 2019/04/29 19:25

[cmsbuild]

+1
Tested at: 6801cb8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26568/34408/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26568/34408/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 42 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

type bugfix

[slava77]

+1

for #26568 6801cb8

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show differences only in ctppsProtons_singleRP variables

e.g. in JetHT2017F reMINIAOD wf 136.8311 there is about a factor of 3 increase in the number of ctppsProtons_singleRP
The change in the collection size looks consistent with the underlying issue fixed in this PR (the count at 2 doesn't have much change; while 0 is now replaced with some entries in the distribution).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1