New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead assignments inside CSCRawToDigi #26574
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,7 +172,6 @@ void CSCDDUEventData::unpack_data(const uint16_t *buf, CSCDCCExaminer* examiner) | |
std::cout << i << " " << std::hex << buf[4*i+3] << " " << buf[4*i+2] << " " | ||
<< buf[4*i+1] << " " << buf[4*i] << std::endl; | ||
} | ||
//std::cout << "DDU Size: " << std::dec << theDDUHeader.sizeInWords() << std::endl; | ||
|
||
theDDUHeader.setFromBuffer(buf); | ||
|
||
|
@@ -196,10 +195,6 @@ void CSCDDUEventData::unpack_data(const uint16_t *buf, CSCDCCExaminer* examiner) | |
{ | ||
theFormatVersion = 2013; | ||
} | ||
|
||
// std::cout << "Format Version: " << theFormatVersion << std::endl; | ||
//std::cout << "sandrik dduID =" << theDDUHeader.source_id() << std::endl; | ||
//int i=-1; | ||
|
||
|
||
// we really don't want to copy CSCEventData's while filling the vec | ||
|
@@ -246,7 +241,6 @@ void CSCDDUEventData::unpack_data(const uint16_t *buf, CSCDCCExaminer* examiner) | |
{ | ||
LogTrace ("CSCDDUEventData|CSCRawToDigi") << "size of vector of cscData = " << theData.size(); | ||
} | ||
// std::cout << std::dec << theDDUTrailer.sizeInWords() << std::endl; | ||
// decode ddu tail | ||
theDDUTrailer.setFromBuffer(inputBuf+dduBufSize); | ||
// memcpy(&theDDUTrailer, dduBlock+(dduBufSize-theDDUTrailer.sizeInWords())*2, theDDUTrailer.sizeInWords()*2); | ||
|
@@ -277,7 +271,6 @@ void CSCDDUEventData::unpack_data(const uint16_t *buf, CSCDCCExaminer* examiner) | |
|
||
} | ||
theSizeInWords = dduBufSize+12; | ||
buf=inputBuf+dduBufSize; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the intention was to modify the pointer passed to this function, then it should have been passed by reference. |
||
|
||
} else { | ||
|
||
|
@@ -326,7 +319,6 @@ void CSCDDUEventData::unpack_data(const uint16_t *buf, CSCDCCExaminer* examiner) | |
theSizeInWords = buf - inputBuf; | ||
} | ||
|
||
//std::cout << "DDUevData Size: " << theSizeInWords << " BUFlast: " << std::hex << inputBuf0[theSizeInWords-4] << //std::endl; | ||
/// Pack Trailer 0 (to access TTS) | ||
theDDUTrailer0 = inputBuf0[theSizeInWords-4]; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -166,26 +166,21 @@ int CSCTMBData::UnpackTMB(const uint16_t *buf) { | |
///determine 2007 or 2006 version | ||
unsigned short int firmwareVersion=0; | ||
int Ntbins = 0 ; | ||
int NHeaderFrames = 0; //WARNING in 5_0_X | ||
int NRPCtbins = 0; // =VB= number of RPC tbins | ||
|
||
int b0cLine=0;///assumes that buf starts at the tmb data | ||
///this is not true if something is wrong in the data | ||
///before TMB - then we skip the whole event | ||
|
||
NHeaderFrames++; NHeaderFrames--; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What was the original intention of this line? |
||
|
||
if (buf[b0cLine]==0xdb0c) { | ||
firmwareVersion=2007; | ||
Ntbins = buf[b0cLine+19]&0xF8; | ||
NRPCtbins = (buf[b0cLine+36]>>5)&0x1F; // =VB= get RPC tbins | ||
NHeaderFrames = buf[b0cLine+5]&0x3F; //WARNING in 5_0_X | ||
} | ||
else if (buf[b0cLine]==0x6b0c) { | ||
firmwareVersion=2006; | ||
Ntbins = buf[b0cLine+1]&0x1f ; | ||
NRPCtbins = Ntbins; | ||
NHeaderFrames = buf[b0cLine+4]&0x1f; //WARNING in 5_0_X | ||
} | ||
else { | ||
LogTrace("CSCTMBData|CSCRawToDigi") << "+++ Can't find b0C flag"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the original intention of this line?