Fix memory usage in PPSUtilities and PPSProtonTransport #26583
Conversation
The variables are now passed as arguments to the appropriate functions.
Moved variables to be stack based instead of heap based Fixed a double delete happening in TotemTransport. The pointer was passed to m_beamPart and then deleted in the function and then later is deleted from m_beamPart.
|
The code-checks are being triggered in jenkins. |
|
|
||
| if(m_verbosity) LogDebug("HectorTransportEventProcessing") << | ||
| "HectorTransport:filterPPS: barcode = " << line << " x= "<< x1_ctpps <<" y= " << y1_ctpps; | ||
|
|
||
| m_beamPart[line] = p_out; | ||
| m_xAtTrPoint[line] = x1_ctpps; | ||
| m_yAtTrPoint[line] = y1_ctpps; | ||
| delete p_out; p_out = nullptr; |
There was a problem hiding this comment.
This delete was invalidating the value of m_beamPart[line].second since the object has been deleted. This was then later deleted again in ProtonTransport::clear().
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26583/9509
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FastSimulation/CTPPSFastTrackingProducer @cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fastsim-approved
fully-signed
simulation-approved
and removed
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
PR validation:
The code compiles.