Migrate Geometry/HGCalCommonData to EventSetup consumes #26591
Conversation
Also fixed a use-after-delete in HGCalNumberingInitialization in case of an IOV change.
Also move away from edm::ESTransientHandle inside HGCGeometryTester::analyze(), because the transient handle should be used only after IOV changes, not for every event.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26591/9517
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@bsunanda FYI |
|
+upgrade |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR migrates all ES and ED modules in Geometry/HGCalCommonData to EventSetup consumes (#26584).
In addition
HGCalNumberingInitializationin case of an IOV changeedm::ESTransientHandleinHGCGeometryTester::analyze(), because the transient handle should be used only after IOV changes, not for every eventPR validation:
Limited matrix runs