Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change depthCor* static members to static std::atomic --thread safety #2664

Merged
merged 1 commit into from Feb 28, 2014
Merged

Change depthCor* static members to static std::atomic --thread safety #2664

merged 1 commit into from Feb 28, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 27, 2014

These parameters are set once in the PFCluster constructor from parameter set
or set once to default values in PFCluster.cc. After that they are only read.
Put ifdefs around std::atomic definitions so that reflex can work.

…hread safety.

These parameters are set once in the PFCluster constructor from parameter set
or set once to default values in PFCluster.cc. After that they are only read.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_1_X.

Change depthCor* static members to static std::atomic --thread safety

It involves the following packages:

DataFormats/ParticleFlowReco

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 28, 2014

+1

for #2664 d2e975b
based on jenkins

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Feb 28, 2014
…wReco

Thread Safety  DataFormats/ParticleFlowReco -- Change depthCor* static members to static std::atomic
@nclopezo nclopezo merged commit 11f37a7 into cms-sw:CMSSW_7_1_X Feb 28, 2014
@gartung gartung deleted the statics-DataFormats-ParticleFlowReco branch March 4, 2014 02:59
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants