[HeaderCheck][ALCA][DB] Cleanup headers to avoid header inconsistency errors

[smuzaffar]

Clean up headers which are not used. The header SerializationManual.h is referenced here https://cmssdt.cern.ch/lxr/source/CondFormats/Serialization/python/condformats_serialization_generate.py#0562

         if os.path.exists( './src/SerializationManual.h' ) :
             source += '#include "%s/%s/src/SerializationManual.h"\n' % (self.split_path[1], self.split_path[2])

but condformats_serialization_generate.py is looking in src directory while deleted header CondFormats/SiPixelObjects/interface/SerializationManual.h is in interface directory.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26641/9600

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondCore/PopCon
CondFormats/Calibration
CondFormats/DTObjects
CondFormats/GeometryObjects
CondFormats/SiPixelObjects

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng, @seemasharmafnal, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34512/console Started: 2019/05/06 12:17

[cmsbuild]

+1
Tested at: 761f9bd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26641/34512/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26641/34512/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[pohsun]

+1

[fabiocos]

@ggovi could you please have a look? The deleted SerializationManual.h is not the one used by the script mentioned by @smuzaffar

[fabiocos]

@ggovi ping

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1