DataFormats/ParticleFlowReco - remove unused data formats

[guitargeek]

PR description:

Follow up on #26184, where a lot of the PFClusterTools code was removed. Actually, the removed code relied on several DataFormats with are now obsolete and should be removed as well.

By the way, are there any CMSSW policies on how we treat the DataFormats? Is their removal allowed, or should they stick in the release forever to ensure backwards compatibility of ROOT files?

PR validation:

Code compiles and local matrix tests pass.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26670/9630

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DataFormats/ParticleFlowReco

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@cbernet, @lgray, @rovere, @bachtis, @hatakeyamak this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34546/console Started: 2019/05/06 20:21

[cmsbuild]

+1
Tested at: e140507
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26670/34546/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26670/34546/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

By the way, are there any CMSSW policies on how we treat the DataFormats? Is their removal allowed, or should they stick in the release forever to ensure backwards compatibility of ROOT files?

We can remove DF classes including dictionaries for transient DFs (something that was never saved in production jobs).
It's worth to go back in history and check if the data was produced in the past.
@guitargeek do you happen to know which ones were used in the standard PF sequences?

For the DFs that were saved in the past, but are no longer expected to be consumed, we can make a dummy dictionary to allow reading the old files. For this: add a struct RemovedXYZClassName {} ; to classes.h.

Only if the old data is still needed for analysis it is worth to keep the DF implementation.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/276/console Started: 2019/05/16 21:36

[cmsbuild]

+1
Tested at: e140507
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aa680/276/summary.html

[cmsbuild]

Comparison job queued.

[guitargeek]

Hi @slava77, sorry I don't happen to know anything about how the classes were used, as they are from the "Snapshot of CMSSW_6_2_0_pre8" commit so it's hard to find some information in an associated PR or something. Maybe @hatakeyamak, @jpata or @bendavid are familiar with it?

The dummy dictionary sounds like a good option to me anyhow, as it probably does not add any compile time whatsoever, no? Then I would not see any drawback.

[slava77]

On 5/16/19 3:17 PM, Jonas Rembser wrote: The dummy dictionary sounds like a good option to me anyhow, as it probably does not add any compile time whatsoever, no? Then I would not see any drawback.

I think that it will be OK to add them only after we see problems in I/O. IIUC, none of the regular production samples have these classes persisted.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aa680/276/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212004
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211668
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #26670 e140507

• this is essentially a technical update to remove unused classes
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1