Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename UP19 to UP21 in matrix workflows and introduce phase1_2021_cosmics key #26688

Merged
merged 1 commit into from May 10, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 8, 2019

PR description:

As a follow-up of comment https://github.com/cms-sw/cmssw/pull/26510/files#r279264544, UP19 is renamed as UP21 in the matrix workflows recently introduced in PR #26510, in the spirit of the migration happening at PR #26535.
I profit of this PR to introduce also a new autoCond key (phase1_2021_cosmics) containing conditions for the 2021 cosmics / beam-halo simulation, as it has been requested here.

PR validation:

runTheMatrix -l 7.23,8.2 runs without issues.

if this PR is a backport please specify the original PR:

This is not a backport.

@boudoul FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26688/9658

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation

@cmsbuild, @prebello, @zhenhu, @christopheralanwest, @tocheng, @pgunnell, @franzoni, @kpedro88, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented May 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26688/9672

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/79/console Started: 2019/05/08 15:29

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

Pull request #26688 was updated. @cmsbuild, @prebello, @zhenhu, @christopheralanwest, @tocheng, @pgunnell, @franzoni, @kpedro88, @tlampen, @pohsun can you please check and sign again.

@boudoul
Copy link
Contributor

boudoul commented May 8, 2019

Thanks @mmusich

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

Pull request #26688 was updated. @cmsbuild, @prebello, @zhenhu, @christopheralanwest, @tocheng, @pgunnell, @franzoni, @kpedro88, @tlampen, @pohsun can you please check and sign again.

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2019

please test workflow 7.23

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/138/console Started: 2019/05/09 23:43

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabiocos
Copy link
Contributor

@tocheng @christopheralanwest @pohsun @kpedro88 @prebello @zhenhu this PR will finalize the 2021 update, fixing the few anticipated crashes in the IB. Could you please check and comment or sign it?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1d8ca/138/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-b1d8ca/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-b1d8ca/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 607 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3055525
  • DQMHistoTests: Total failures: 123
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3055205
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 33 DQM output files

@kpedro88
Copy link
Contributor

+upgrade

@zhenhu
Copy link
Contributor

zhenhu commented May 10, 2019

+1

@tocheng
Copy link
Contributor

tocheng commented May 10, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 848a8a2 into cms-sw:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants