Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[muon] add sim hit match quality and pileup identification information in MiniAOD #26704

Merged

Conversation

drkovalskyi
Copy link
Contributor

This requests adds two numbers for each muon to improve physics analyzers to interpret muon matching information. The information is copied from the corresponding value map, which is only available in AODSIM and such samples are not available in most cases for physics analysis.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26704/9684

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

A new Pull Request was created by @drkovalskyi for master.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @hatakeyamak, @rappoccio, @HeinerTholen, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @acaudron, @jdolen, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented May 8, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/92/console Started: 2019/05/08 19:08

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17986b/92/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented May 9, 2019

+1

for #26704 b479770

  • code changes are in line with the PR description. The changes are pretty straightforward.
  • jenkins tests pass and comparisons with the baseline show no differences (the newly added data members are not monitored)

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2019

merge

@cmsbuild cmsbuild merged commit bab3e4b into cms-sw:master May 9, 2019
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants