Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes so that no package creates its own root file #2672

Conversation

apsallid
Copy link
Contributor

Changed two flags since no package must create its own root file.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apsallid for CMSSW_7_1_X.

changes so that no package creates its own root file

It involves the following packages:

Validation/RecoTrack
Validation/TrackerRecHits

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 4, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 4, 2014
…coTrack_SiStripTrackingRecHitsValid

DQM -- Changes so that no package creates its own root file
@ktf ktf merged commit c59a576 into cms-sw:CMSSW_7_1_X Mar 4, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants