Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tabs to spaces to avoid complaints from the python3 compiler #26720

Merged
merged 1 commit into from May 9, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented May 9, 2019

PR description:

To fix a problem reported by the IB after the integration of #26526 .
In practice I have just applied M-x untabify in emacs.

PR validation:

09:52 cmsdev25 5605> CMD_python=$(which python3) scram b -r -v -k CompilePython
Resetting caches
>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Done python_symlink
>> Compiling python modules cfipython/slc7_amd64_gcc700
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-05-08-2300/external/slc7_amd64_gcc700/bin/python3 -m compileall -q cfipython/slc7_amd64_gcc700
>> Compiling python modules python
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-05-08-2300/external/slc7_amd64_gcc700/bin/python3 -m compileall -q python
>> Compiling python modules src/Alignment/OfflineValidation/python
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-05-08-2300/external/slc7_amd64_gcc700/bin/python3 -m compileall -q src/Alignment/OfflineValidation/python
>> All python modules compiled

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26720/9707

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Alignment/OfflineValidation

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented May 9, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/116/console Started: 2019/05/09 10:04

@fabiocos
Copy link
Contributor Author

fabiocos commented May 9, 2019

+1

just tabs replaced with spaces in a python utility, nothing to be really tested

@fabiocos
Copy link
Contributor Author

fabiocos commented May 9, 2019

merge

@cmsbuild cmsbuild merged commit bdd053f into cms-sw:master May 9, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c03d27/116/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants