Modernized ES modules in Geometry/MTDNumberingBuilder #26734
Conversation
-Merged header and src for MTDGeometricTimingDetESModule -Added consumes calls to MTDGeometricTimingDetESModule -Removed unnecessary sate from Construction classes -Use std::unique_ptr instead of bare pointers
-Merged header and src files -Added consumes calls -Various other improvements
-Merged header and source files -Added consumes calls -Changed member data to be function local variables
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26734/9723
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: Geometry/MTDNumberingBuilder @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
The tests are being triggered in jenkins. |
|
associated with #26584 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Related to this package, I noticed an EDAnalyzer defined in |
|
Having a module in |
|
This was copied from https://github.com/cms-sw/cmssw/tree/master/Geometry/TrackerNumberingBuilder/bin/stubs, so it has been around since 2007. |
|
The MTD reconstruction geometry is slightly more than a clone of the Tracker one... |
|
... of course this does not mean it should not be cleaned |
|
+upgrade |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
PR validation:
Code compiles