Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic problems in MuScleFitBase #26768

Merged
merged 5 commits into from May 16, 2019
Merged

Fix logic problems in MuScleFitBase #26768

merged 5 commits into from May 16, 2019

Commits on May 13, 2019

  1. Use an std::unique_ptr to own the temporary TFile

    @Dr15Jones
    Dr15Jones committed May 13, 2019
    Copy the full SHA
    68ed576 View commit details
    Browse the repository at this point in the history

  2. Use consistent logic when using histograms 

    Everywhere in readProbabilityDistributionsFromFile where histograms
are used conditionally, the logic for the condition are now identical.

Problems with the logic were identified by the static analyzer and
gcc 9.
    @Dr15Jones
    Dr15Jones committed May 13, 2019
    Copy the full SHA
    7c0289e View commit details
    Browse the repository at this point in the history

  3. Use std::array instead of C arrays 

    This allows specifying the size only once.
    @Dr15Jones
    Dr15Jones committed May 13, 2019
    Copy the full SHA
    f391429 View commit details
    Browse the repository at this point in the history

  4. Initialize the histogram arrays with nullptr

    @Dr15Jones
    Dr15Jones committed May 13, 2019
    Copy the full SHA
    6bd97bf View commit details
    Browse the repository at this point in the history

  5. Applied code-checks patch

    @Dr15Jones
    Dr15Jones committed May 13, 2019
    Copy the full SHA
    68030ea View commit details
    Browse the repository at this point in the history