Fixes for code rule violations in Validation/RecoB and HLTriggerOffline/SUSYBSM

[fabiocos]

PR description:

During the recent code-format migration, that is systematically accessing all the packages, two code rules violations have been spotted in Validation/RecoB and HLTriggerOffline/SUSYBSM. This PR addresses them, with the exception so far of one try - catch block whose purpose is not clear to me.

PR validation:

Code compiles and passes basic code quality tests.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26772/9770

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

HLTriggerOffline/SUSYBSM
Validation/RecoB

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@mtosi, @smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/198/console Started: 2019/05/14 10:05

[cmsbuild]

+1
Tested at: 9a4ed92
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6da576/198/summary.html

[cmsbuild]

Comparison job queued.

[fabiocos]

@slava77 @perrotta @Martin-Grunewald in your experience is it clear what is the purpose of this try - catch protection
https://cmssdt.cern.ch/lxr/source/HLTriggerOffline/SUSYBSM/src/SUSY_HLT_SingleLepton.cc#0068 ?
If at this point both the validity of the GsfElectron track and of the conversion is checked, I am not sure what other kind of protection is possibly needed. Browsing around for similar patters I do no see such kind of test.

[slava77]

just git grepping shows that https://cmssdt.cern.ch/lxr/source/HLTriggerOffline/SUSYBSM/src/SUSY_HLT_SingleLepton.cc#0068 is the only place where try/catch is used on this method.
I don't know offhand why it would throw.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6da576/198/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212004
• DQMHistoTests: Total failures: 131
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211669
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26772/9777

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #26772 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/210/console Started: 2019/05/14 16:42

[cmsbuild]

+1
Tested at: 74b8a63
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6da576/210/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6da576/210/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212004
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211669
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1