Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 106X global tags in data and 2021/2023 MC [backport] #26781

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR updates offline, prompt-like and 2021 MC global tags in 10_6_X. It is a backport of PR #26773 to 10_6_X.

PR validation:

See the description in PR #26773.

if this PR is a backport please specify the original PR:

This is a backport of PR #26773 to 10_6_X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for CMSSW_10_6_X.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/214/console Started: 2019/05/14 22:40

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47b4a8/214/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4389 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 6060
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3205603
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 136.788 ): 0.008 KiB JetMET/SUSYDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@mmusich
Copy link
Contributor

mmusich commented May 20, 2019

@christopheralanwest @tocheng is there any showstopper with this PR?
Please clarify

@cmsbuild
Copy link
Contributor

Pull request #26781 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please check and sign again.

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 20, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/358/console Started: 2019/05/20 23:30

@christopheralanwest christopheralanwest changed the title Update 106X global tags in data and 2021 MC [backport] Update 106X global tags in data and 2021/2023 MC [backport] May 20, 2019
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47b4a8/358/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14184 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 12428
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3199235
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 136.788 ): 0.008 KiB JetMET/SUSYDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

Changes are seen and expected in comparison tests for

-- PPS quantities only in 2018 RECO (136.85)
-- 2017 data RECO (136.788)
-- 2021 (11624.0) and 2023 (20034.0, 21234.0, 27434.0, and 29034.0) MC

No changes are seen in other workflows.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@prebello
Copy link
Contributor

@christopheralanwest please what do you mean exactly? did you test all sort of relvals? we have already used 106X_upgrade2021_realistic_v4 in the 2021 relvals in 10-6-0. What sort of changes are expected? Thank you.

@fabiocos
Copy link
Contributor

@christopheralanwest @franzoni @srimanob I understand that this is the PR we discussed at the PPD general meeting with the phase2 GT update for ECAL, am I correct? Am I also correct in understanding that it can be merged without any of the other further code addition and provide the correct results?

@christopheralanwest
Copy link
Contributor Author

@fabiocos Yes, that is correct.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 08a6399 into cms-sw:CMSSW_10_6_X May 24, 2019
@christopheralanwest christopheralanwest deleted the alca-106X-gt-backport branch August 21, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants