New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[106X] MTV : adjust impact parameter selection (backport of #26700) #26783
Conversation
A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_6_X. It involves the following packages: Validation/RecoTrack @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@mtosi FYI |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
from Configuration.ProcessModifiers.premix_stage2_cff import premix_stage2 | ||
premix_stage2.toModify(multiTrackValidator, | ||
label_tv = "mixData:MergedTrackTruth", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this change in #26700. This customization is irrelevant as the parameter is not used by MultiTrackValidatorGenPs
(but it doesn't hurt either).
@mtosi this PR is only changing histograms in 1XXXX and 2XXXX workflows but 25202, I understand this is the expected behaviour right? |
ciao [1] |
Thank you @mtosi |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
See the discussion in #26700 (comment)
PR validation:
All tests passed
if this PR is a backport please specify the original PR: #26700