Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[106X] MTV : adjust impact parameter selection (backport of #26700) #26783

Merged
merged 4 commits into from Jun 5, 2019

Conversation

fabiocos
Copy link
Contributor

PR description:

See the discussion in #26700 (comment)

PR validation:

All tests passed

if this PR is a backport please specify the original PR: #26700

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_6_X.

It involves the following packages:

Validation/RecoTrack

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

@mtosi FYI

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/222/console Started: 2019/05/15 09:56

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a701b2/222/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 4046
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3207624
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@mtosi
Copy link
Contributor

mtosi commented May 15, 2019

@jalimena
Copy link
Contributor

@emiglior @makortel

from Configuration.ProcessModifiers.premix_stage2_cff import premix_stage2
premix_stage2.toModify(multiTrackValidator,
label_tv = "mixData:MergedTrackTruth",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this change in #26700. This customization is irrelevant as the parameter is not used by MultiTrackValidatorGenPs (but it doesn't hurt either).

@jfernan2
Copy link
Contributor

@mtosi this PR is only changing histograms in 1XXXX and 2XXXX workflows but 25202, I understand this is the expected behaviour right?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_6_X_2019-05-14-2300+a701b2/31690/dqm-histo-comparison-summary.html

@mtosi
Copy link
Contributor

mtosi commented May 16, 2019

ciao
thanks for this comment
I've just checked the workflow (by heart I do not remember the map) [1]
the 25202 refers to --era Run2_2016, which has the Phase0 pixel detector
and therefore the original cut on the d_0 is perfectly fine

[1]
runTheMatrix.py -l 25202 --dryRun

@jfernan2
Copy link
Contributor

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

fabiocos commented Jun 5, 2019

+1

@cmsbuild cmsbuild merged commit e361777 into cms-sw:CMSSW_10_6_X Jun 5, 2019
@fabiocos fabiocos deleted the fc-bp26700TO106X branch December 18, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants