Phase2-hgx196 Handle the current issues of validation

[bsunanda]

PR description:

Correct small bugs in HGCalSimHitValidation, HGCalHitStudy and HGCalHitCalibration codes

PR validation:

Tested with standard runTheMatrix

if this PR is a backport please specify the original PR:

No back porting is required

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26793/9794

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Validation/HGCalValidation

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @rovere, @lgray, @cseez, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/240/console Started: 2019/05/15 23:42

[cmsbuild]

+1
Tested at: ae21f8e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-498e57/240/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-498e57/240/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212004
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211660
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[jfernan2]

@bsunanda Your PR is only adding entries in 4 plots on Workflows
27434.0
29034.0
Is this intended?
I guess so since they are Upgrade samples but not the only ones
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_0_X_2019-05-15-1100+498e57/31702/dqm-histo-comparison-summary.html

[bsunanda]

Yes. The issues in the validation code were discussed in the DPG meeting. The issues were small: change of silicon thickness in one and empty histograms in some of the standalone code. So it will change minimally in the output - some plots will be filled up in the calibration part and that is all.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1