Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport STXS Stage 1.1 to 10_2_X #26794

Merged
merged 4 commits into from May 23, 2019
Merged

Backport STXS Stage 1.1 to 10_2_X #26794

merged 4 commits into from May 23, 2019

Conversation

yhaddad
Copy link
Contributor

@yhaddad yhaddad commented May 16, 2019

This PR is a backport from #26724 to 10_2_X.

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone May 16, 2019
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yhaddad (Yacine Haddad) for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/RivetInterface
SimDataFormats/HTXS

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@efeyazgan
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/244/console Started: 2019/05/16 09:33

@cmsbuild
Copy link
Contributor

Pull request #26794 was updated. @alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please check and sign again.

@efeyazgan
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/246/console Started: 2019/05/16 10:03
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/250/console Started: 2019/05/16 10:54

@cmsbuild
Copy link
Contributor

+1
Tested at: 811d33d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-538742/246/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

+1
Tested at: 811d33d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-538742/250/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-538742/250/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007209
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2019 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #26854,cms-sw/cmsdist#4967
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/393/console Started: 2019/05/21 23:40

@cmsbuild cmsbuild mentioned this pull request May 21, 2019
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2019 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #26854,cms-sw/cmsdist#4967,cms-sw/cmsdist#4970
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/395/console Started: 2019/05/22 00:12

@cmsbuild cmsbuild mentioned this pull request May 21, 2019
Merged
@cmsbuild
Copy link
Contributor

-1

Tested at: 45dbe7d

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d656f1c
0b42eab
10d7de1
18046ad
3f603c6
5d36548
c784d1b
9645035
d45b960
cfa6b73
1c02bd1
592a465
34cf625
10f8b55
7dbf56d
6c09dda
50905eb
c193160
c46f51a
7ff9cc4
9a2728a
4bbadca
1a31a0b
213aaa7
fa26e0e
3eff012
b6cf990
ac5914a
90a3df9
91b95bf
e61b086
cfc81fb
eaa532d
5db1602
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26794/395/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26794/395/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d3eb9/395/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
136.8521 step2

runTheMatrix-results/136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018+HARVESTNANOAOD2018/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018+HARVESTNANOAOD2018.log
10824.0 step6 
runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d656f1c
0b42eab
10d7de1
18046ad
3f603c6
5d36548
c784d1b
9645035
d45b960
cfa6b73
1c02bd1
592a465
34cf625
10f8b55
7dbf56d
6c09dda
50905eb
c193160
c46f51a
7ff9cc4
9a2728a
4bbadca
1a31a0b
213aaa7
fa26e0e
3eff012
b6cf990
ac5914a
90a3df9
91b95bf
e61b086
cfc81fb
eaa532d
5db1602
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26794/395/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26794/395/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2019 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #26854,cms-sw/cmsdist#4967,cms-sw/cmsdist#4970
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/410/console Started: 2019/05/22 11:06

@cmsbuild
Copy link
Contributor

+1
Tested at: 45dbe7d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d3eb9/410/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
62be0dc
0b42eab
10d7de1
18046ad
3f603c6
5d36548
c784d1b
9645035
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26794/410/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26794/410/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d3eb9/410/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 202 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007440
  • DQMHistoTests: Total failures: 34
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 3007207
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 25.727 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 25.727 KiB Physics/NanoAODDQM
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7765a36 into cms-sw:CMSSW_10_2_X May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed generators-approved orp-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yhaddad @cmsbuild @efeyazgan @peruzzim @qliphy @fabiocos