Running code-format for geometry

[cmsbuild]

Applying code-format for CMSSW category geometry.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/229//console

cms-bot has successfully run the following:

• scram build code-checks-all
• scram build code-format-all
• scram build

[cmsbuild]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26815/9832

• This PR adds an extra 8KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/293/console Started: 2019/05/17 08:50

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

Geometry/CaloEventSetup
Geometry/HcalEventSetup
Geometry/VeryForwardGeometry

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@forthommel, @jan-kaspar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

It’s 3000-some line changes and the git diff doesn’t display it well. Perhaps we could apply the check per single package?

[smuzaffar]

@ianna , 1 PR per package means too many PRs and too much resources to test.
Which looking for files changes , you can click on "Diff settings" button and select "Hide whitespace changes" to ignore any white spaces related changes.

[cmsbuild]

+1
Tested at: a08fde0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-056fad/293/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-056fad/293/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212004
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211669
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cvuosalo]

I am inclined to approve this PR, but maybe @ianna still has an objection?

[fabiocos]

@cvuosalo @ianna as far as I can see the PR is ok, as many others already merged, I haven't spotted any special issue. I would like to move forward soon with its integration, unless you have an explicit problem to report

[fabiocos]

+1

@ianna @cvuosalo in case you see some issue please comment for a follow-up

[fabiocos]

merge

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)