Running code-format for hlt #26840
Running code-format for hlt #26840
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26840/9868
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: HLTrigger/Egamma @Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| }else if(!clusCands.empty()){ //try trigger cluster (should never be this, at the time of writing (17/1/11) this would indicate an error) | ||
| for(auto & clusCand : clusCands){ | ||
| } else if (!clusCands | ||
| .empty()) { //try trigger cluster (should never be this, at the time of writing (17/1/11) this would indicate an error) |
There was a problem hiding this comment.
@smuzaffar in principle als this case looks a bit bizarre, always because of the long comment
| PrevFilterOutput->getObjects(TriggerPhoton, mysortedrecoecalcands); | ||
| if (mysortedrecoecalcands.empty()) | ||
| PrevFilterOutput->getObjects(TriggerCluster, | ||
| mysortedrecoecalcands); //we dont know if its type trigger cluster or trigger photon |
There was a problem hiding this comment.
@smuzaffar or here for instance ...
| }else if(!clusCands.empty()){ //try trigger cluster (should never be this, at the time of writing (17/1/11) this would indicate an error) | ||
| for(auto & clusCand : clusCands){ | ||
| } else if (!clusCands | ||
| .empty()) { //try trigger cluster (should never be this, at the time of writing (17/1/11) this would indicate an error) |
There was a problem hiding this comment.
of course we are not alone on earth
https://stackoverflow.com/questions/44731978/make-clang-format-ignore-comments-for-line-break
There was a problem hiding this comment.
the thread is from 2 years ago. It looks "unfixable".
|
+1 |
Applying code-format for CMSSW category hlt.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/236//console
cms-bot has successfully run the following: